mbox series

[0/3] gpio-rockchip driver

Message ID 20210322104310.863029-1-jay.xu@rock-chips.com
Headers show
Series gpio-rockchip driver | expand

Message

Jianqun Xu March 22, 2021, 10:43 a.m. UTC 
Separate gpio driver from pinctrl driver.

Jianqun Xu (3):
  pinctrl/rockchip: separate struct rockchip_pin_bank to a head file
  pinctrl/pinctrl-rockchip.h: add pinctrl device to gpio bank struct
  gpio: separate gpio driver from pinctrl-rockchip driver

 drivers/gpio/Kconfig               |   8 +
 drivers/gpio/Makefile              |   1 +
 drivers/gpio/gpio-rockchip.c       | 650 +++++++++++++++++++++
 drivers/pinctrl/pinctrl-rockchip.c | 909 +----------------------------
 drivers/pinctrl/pinctrl-rockchip.h | 246 ++++++++
 5 files changed, 924 insertions(+), 890 deletions(-)
 create mode 100644 drivers/gpio/gpio-rockchip.c
 create mode 100644 drivers/pinctrl/pinctrl-rockchip.h

Comments

Linus Walleij March 22, 2021, 12:54 p.m. UTC | #1 
Hi Jianqun,

On Mon, Mar 22, 2021 at 11:43 AM Jianqun Xu <jay.xu@rock-chips.com> wrote:

> Separate gpio driver from pinctrl driver.
>
> Jianqun Xu (3):
>   pinctrl/rockchip: separate struct rockchip_pin_bank to a head file
>   pinctrl/pinctrl-rockchip.h: add pinctrl device to gpio bank struct
>   gpio: separate gpio driver from pinctrl-rockchip driver
>
>  drivers/gpio/Kconfig               |   8 +
>  drivers/gpio/Makefile              |   1 +
>  drivers/gpio/gpio-rockchip.c       | 650 +++++++++++++++++++++
>  drivers/pinctrl/pinctrl-rockchip.c | 909 +----------------------------
>  drivers/pinctrl/pinctrl-rockchip.h | 246 ++++++++
>  5 files changed, 924 insertions(+), 890 deletions(-)

This is a very nice change (separation of concerns!)
I'm just pinging to include Bartosz on this patch set so
he knows a new GPIO driver may be appearing through
the pinctrl tree (and he may want to take a look).

Yours,
Linus Walleij
Linus Walleij April 8, 2021, 1:43 p.m. UTC | #2 
On Mon, Mar 22, 2021 at 11:43 AM Jianqun Xu <jay.xu@rock-chips.com> wrote:

> Separate gpio driver from pinctrl driver.

I tried to apply this too, but it fails, can you rebase on the pinctrl "devel"
branch (I suppose the RK3568 driver got in the way).

Yours,
Linus Walleij