From patchwork Wed Feb 10 07:49:45 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Drew Fustini X-Patchwork-Id: 1438840 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-gpio-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=beagleboard-org.20150623.gappssmtp.com header.i=@beagleboard-org.20150623.gappssmtp.com header.a=rsa-sha256 header.s=20150623 header.b=eWZSDwoG; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4DbBmX0RwYz9sS8 for ; Wed, 10 Feb 2021 18:51:56 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233048AbhBJHvd (ORCPT ); Wed, 10 Feb 2021 02:51:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40632 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232895AbhBJHvU (ORCPT ); Wed, 10 Feb 2021 02:51:20 -0500 Received: from mail-pj1-x102d.google.com (mail-pj1-x102d.google.com [IPv6:2607:f8b0:4864:20::102d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 99CB8C061756 for ; Tue, 9 Feb 2021 23:50:40 -0800 (PST) Received: by mail-pj1-x102d.google.com with SMTP id cl8so661331pjb.0 for ; Tue, 09 Feb 2021 23:50:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=beagleboard-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=dTtAvYfpCAcrkzC7wHtQialOzV1hp5H4iMa/77gI7mk=; b=eWZSDwoGqrZMTV/VLE4FtZw4sBdMmTx5WkshbNDjoBWjyGkvjUTjehzIsjlRTNGBIj xqMIV+Ec57zH1hmba6n6ajF40OkNARptoo/pOdXdQCsg1UuyhQbGGW7jNI6GwgUQ89uX MasfuQ6fQwPsLeBDrdTGPI0Ba6lT7ipg9eOXwKWeh341v+G1LCyi/6k5/eBH+jtj2bSF PXtQqaPG0UMv7Ocl/SpeoKHWixb5hfWx4XhxdmQflO1H74aMROGangUw7aAPPHvj/uuO +KXvTx6eoP51cJ3lpv4+X8f3FBYakq0uYrcowrTiZuXAt00NDZ36ANqcdtiONfeILL7+ +omQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=dTtAvYfpCAcrkzC7wHtQialOzV1hp5H4iMa/77gI7mk=; b=EgUk5nQamEeFwiTPyklcubTKUvb/MUTSwyhpMVIndPte0PZmNPOVHnH307G1VZaZFI +vgCt9XBEj1igQCGJX6HmbZbEzZSwEL5Jzm53PQHlVD6WN2d6J6mNH/cigSEwa2PvX/c PVzgwSawzpHqk2uhyjPqrtZqOZvgWKWP+4gfcini2vMlKtqUQw9etTPOuDyX1RcZmHlM k8YpUaCy4oDwCWM8KTqhNHBsyDZasgludTTZqrdqb4EW/SbCXjvIovxNY6sPN24ctFGZ 9pUMjKryEr4ypC3r/dGPLSUJgZTCPb+Bc5CNedavTQ6dja28M97lAt6DWy0zDBlkXd04 Scdw== X-Gm-Message-State: AOAM530EWfVMCfmxjtlzar/nnL9ZhWlguXQj6A6LxtgnNl/ksdSA17YB b4lo7mkLR2N5dyGg5lJsUyfgMg== X-Google-Smtp-Source: ABdhPJxHIKSl0BtQ9fc8/TOqMq2PgYbqhBz09VnwjEFmn4XRd1fL1x4zXAjRA452FJMkcpPJfsZGJw== X-Received: by 2002:a17:90a:6944:: with SMTP id j4mr1938527pjm.48.1612943440074; Tue, 09 Feb 2021 23:50:40 -0800 (PST) Received: from x1.hsd1.or.comcast.net ([2601:1c0:4701:ae70:7b19:df69:92d6:528e]) by smtp.gmail.com with ESMTPSA id b25sm1261710pfp.26.2021.02.09.23.50.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Feb 2021 23:50:39 -0800 (PST) From: Drew Fustini To: Linus Walleij , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Tony Lindgren , Andy Shevchenko , Alexandre Belloni , Geert Uytterhoeven , Pantelis Antoniou , Jason Kridner , Robert Nelson Cc: Drew Fustini Subject: [PATCH v2 0/2] pinctrl: pinmux: Add pinmux-select debugfs file Date: Tue, 9 Feb 2021 23:49:45 -0800 Message-Id: <20210210074946.155417-1-drew@beagleboard.org> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org This series first converts the debugfs files in the pinctrl subsystem to octal permissions and then adds a new debug file "pinmux-select". Function name and group name can be written to "pinmux-select" which will cause the function and group to be activated on the pin controller. Notes for PATCH v2: - create patch series that includes patch to switch all the debugfs files in pinctrl subsystem over to octal permission - write function name and group name, instead of error-prone selector numbers, to the 'pinmux-select' file - switch from static to dynamic allocation for the kernel buffer filled by strncpy_from_user() - look up function selector from function name using pinmux_func_name_to_selector() - validate group name with get_function_groups() and match_string() - look up selector for group name with pinctrl_get_group_selector() Notes for PATCH v1: - posted seperate patch to switch all the debugfs files in pinctrl subsystem over to octal permission [1] - there is no existing documentation for any of the debugfs enteries for pinctrl, so it seemed to have a bigger scope than just this patch. I also noticed that rst documentation is confusingly named "pinctl" (no 'r') and started thread about that [2]. Linus suggested chaning that to 'pin-control'. Thus I am planning a seperate documentation patch series where the file is renamed, references changed and a section on the pinctrl debugfs files is added. Notes for RFC v2 [3]: - rename debugfs file "pinmux-set" to "pinmux-select" - renmae pinmux_set_write() to pinmux_select() - switch from memdup_user_nul() to strncpy_from_user() - switch from pr_warn() to dev_err() [1] https://lore.kernel.org/linux-gpio/20210126044742.87602-1-drew@beagleboard.org/ [2] https://lore.kernel.org/linux-gpio/20210126050817.GA187797@x1/ [3] https://lore.kernel.org/linux-gpio/20210123064909.466225-1-drew@beagleboard.org/ Drew Fustini (2): pinctrl: use to octal permissions for debugfs files pinctrl: pinmux: Add pinmux-select debugfs file drivers/pinctrl/core.c | 6 +-- drivers/pinctrl/pinconf.c | 4 +- drivers/pinctrl/pinmux.c | 110 +++++++++++++++++++++++++++++++++++++- 3 files changed, 113 insertions(+), 7 deletions(-)