mbox series

[v2,0/1] pinctrl: iproc: Fix level interrupt handling

Message ID 20191215210503.15488-1-hamish.martin@alliedtelesis.co.nz
Headers show
Series pinctrl: iproc: Fix level interrupt handling | expand

Message

Hamish Martin Dec. 15, 2019, 9:05 p.m. UTC 
An issue is seen on the BCM56060 SoC using the pinctrl-iproc-gpio.c driver
for one of its GPIO blocks.
When a GPIO on this block is used as a level sensitive interrupt the
downstream handler is not invoked until the level returns to its previous
(non-interrupting) state. This makes the level sensitive interrupts
unusable. Edge sensitive interrupts are not affected.

The fix is to simply ensure that we use a more appropriate handler
(handle_level_irq) for the interrupt based on what trigger type has been
configured.
Similar setting of the handler is done in numerous other drivers.

v2: Fixes for Ray Jui's review comments.

Hamish Martin (1):
  pinctrl: iproc: Set irq handler based on trig type

 drivers/pinctrl/bcm/pinctrl-iproc-gpio.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)