mbox series

[v2,0/3] pinctrl: cherryview: Pass irqchip when adding gpiochip

Message ID 20191106154715.155596-1-hdegoede@redhat.com
Headers show
Series pinctrl: cherryview: Pass irqchip when adding gpiochip | expand

Message

Hans de Goede Nov. 6, 2019, 3:47 p.m. UTC
Hi All,

Here is v2 of my series for Cherry Trail devices to pass the irqchip when
adding the gpiochip instead of registering it separately. Similar to how
this is done for Bay Trail devices in Andy's recent series:
"[RESEND][PATCH v2 0/7] gpiolib: fix GPIO <-> pin mapping registration".

Note this series depends on that series as well as on the cherryview changes
currently queued in pinctrl/intel.git/for-next .

Changes in v2:
- Add kerndoc comments for new chv_pinctrl struct members

Regards,

Hans

Comments

Andy Shevchenko Nov. 6, 2019, 4:18 p.m. UTC | #1
On Wed, Nov 06, 2019 at 04:47:12PM +0100, Hans de Goede wrote:
> Hi All,
> 
> Here is v2 of my series for Cherry Trail devices to pass the irqchip when
> adding the gpiochip instead of registering it separately. Similar to how
> this is done for Bay Trail devices in Andy's recent series:
> "[RESEND][PATCH v2 0/7] gpiolib: fix GPIO <-> pin mapping registration".
> 
> Note this series depends on that series as well as on the cherryview changes
> currently queued in pinctrl/intel.git/for-next .

LGTM independently on the discussion in patch 3

> 
> Changes in v2:
> - Add kerndoc comments for new chv_pinctrl struct members
> 
> Regards,
> 
> Hans
>
Mika Westerberg Nov. 6, 2019, 5:47 p.m. UTC | #2
On Wed, Nov 06, 2019 at 04:47:12PM +0100, Hans de Goede wrote:
> Hi All,
> 
> Here is v2 of my series for Cherry Trail devices to pass the irqchip when
> adding the gpiochip instead of registering it separately. Similar to how
> this is done for Bay Trail devices in Andy's recent series:
> "[RESEND][PATCH v2 0/7] gpiolib: fix GPIO <-> pin mapping registration".
> 
> Note this series depends on that series as well as on the cherryview changes
> currently queued in pinctrl/intel.git/for-next .
> 
> Changes in v2:
> - Add kerndoc comments for new chv_pinctrl struct members

The series looks good to me now. Thanks!

Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Andy Shevchenko Nov. 7, 2019, 9:41 a.m. UTC | #3
On Wed, Nov 06, 2019 at 07:47:59PM +0200, Mika Westerberg wrote:
> On Wed, Nov 06, 2019 at 04:47:12PM +0100, Hans de Goede wrote:
> > Hi All,
> > 
> > Here is v2 of my series for Cherry Trail devices to pass the irqchip when
> > adding the gpiochip instead of registering it separately. Similar to how
> > this is done for Bay Trail devices in Andy's recent series:
> > "[RESEND][PATCH v2 0/7] gpiolib: fix GPIO <-> pin mapping registration".
> > 
> > Note this series depends on that series as well as on the cherryview changes
> > currently queued in pinctrl/intel.git/for-next .
> > 
> > Changes in v2:
> > - Add kerndoc comments for new chv_pinctrl struct members
> 
> The series looks good to me now. Thanks!
> 
> Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>

Pushed to my review-andy branch for better testing coverage, though it's not an
immediate candidate for v5.5 due to dependencies.