From patchwork Mon Nov 4 15:38:34 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kent Gibson X-Patchwork-Id: 1189017 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-gpio-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="UVYsHOfq"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 476H644Dpvz9sP3 for ; Tue, 5 Nov 2019 02:39:24 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728321AbfKDPjX (ORCPT ); Mon, 4 Nov 2019 10:39:23 -0500 Received: from mail-pf1-f194.google.com ([209.85.210.194]:35257 "EHLO mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727891AbfKDPjX (ORCPT ); Mon, 4 Nov 2019 10:39:23 -0500 Received: by mail-pf1-f194.google.com with SMTP id d13so12431987pfq.2 for ; Mon, 04 Nov 2019 07:39:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=BTFhoX2oDcK2kapAfNOJGwSYYXyoZZOx95OuVwHx5jg=; b=UVYsHOfqGt9CYnCY9nXyy/tLLt4pq5INX4HzMNYUsbN2OvVlm+0tWAIKiGxe4FiINU vQUwN79cbtoaGbVeep3vLUjZwtZQFYkdVHq+OYOz/BdEc91ZeRjGt309tEl5ewxl0I46 h4tb3ujhzev/iQ0jKXD3UQLsl1PMvEzqoXiJnb4YzZ6KBMBZwYY22tztn+PuRyt3DLTx Z6SJYnfCQkG+Pjwcj8JM4gcOLD1/dUab6dUzfaoOm13zpzJ2WLurtEuxQNFNlpDIGH/e 9ZmHcCqyn5mi8mqcZLfG2aRzdnobhHW0UqlYpL1OIT5MxKPTcko0ZvZwSTmwBvwgu+Hv ZeVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=BTFhoX2oDcK2kapAfNOJGwSYYXyoZZOx95OuVwHx5jg=; b=PszcaEf6JpEMiKQSC1Qy5vnceOBXqSDUFrgyF0XGuYz3NT97y1pc9q3vdf1D9hzuxy ffgtF4/8SFfHAKlDwG6zHo3OLsq40onc7EkLdRQAuJLqCNikX+dmI2XJbYP8s6sjbYOn HA57J4RkOgTq8UXpsOrbqG2jY/jPLbj5X20d3i+upGzFzOfZxqEcK9qLoBpyWR5p/YLW cgwY/0r7YnmHuxtTaOPVMN+6SG47ENdB0ueOF6xcIUZQK7AyurlM7nQhRoWFnzX4C+DL Z8IEkKH9DYag1H5vrFkAGGMH4UFHbwNf0N3Eqm583jZ5eKKLzsvgbjuHVZlJziRL0xha q1fQ== X-Gm-Message-State: APjAAAXm2QGle+OPkqzqHCh3V5XPE3c6MoTqMNc7IP4Fj2PE9TNTvl8w 1i1zywH9Pl9EOCFrlFl+trxmvqbONerrvw== X-Google-Smtp-Source: APXvYqyJtxNESpH0dSkije/ulZ2LcEvJP5IR1VKY+2w9F5VM5YL1fhgycidFkhFPCjG+U4KxQ+spvw== X-Received: by 2002:a63:ef51:: with SMTP id c17mr30857304pgk.43.1572881962208; Mon, 04 Nov 2019 07:39:22 -0800 (PST) Received: from sol.lan (220-235-109-115.dyn.iinet.net.au. [220.235.109.115]) by smtp.gmail.com with ESMTPSA id a66sm5819761pfb.166.2019.11.04.07.39.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Nov 2019 07:39:21 -0800 (PST) From: Kent Gibson To: linux-gpio@vger.kernel.org, bgolaszewski@baylibre.com, linus.walleij@linaro.org, bamv2005@gmail.com Cc: drew@pdp7.com, thomas.petazzoni@bootlin.com, Kent Gibson Subject: [PATCH v5 0/7] gpio: expose line bias flags to userspace Date: Mon, 4 Nov 2019 23:38:34 +0800 Message-Id: <20191104153841.16911-1-warthog618@gmail.com> X-Mailer: git-send-email 2.23.0 MIME-Version: 1.0 Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org The changes from v4: Review changes: - relocate restriction on applying bias to as-is from patch 2 to patch 1. - propagate errors, other than ENOTSUPP, from gpio_set_bias. (squashed into patches 3 and 4). - include SET_CONFIG patch series v2 (patch 6 and 7 here). I've also fixed a few other nits I noticed along the way: - rework gpio_set_bias as flags are mutually exclusive. - remove input flag required to set bias restriction from lineevent_create as events are implicitly assumed inputs anyway. - reorder patches to group gpiolib bias patches together before the gpio-mockup changes. This series adds gross control of pull-up/pull-down to the GPIO uAPI. Gross control means enabling and disabling of bias functionality, not finer grained control such as setting biasing impedances. The support allows both input and output lines to have any one of the following biases applied as part of the line handle or event request: 0. As Is - bias is left alone. This is the default for ABI compatibility. 1. Bias Disable - bias is explicitly disabled. 2. Pull Down - pull-down bias is enabled. 3. Pull Up - pull-up bias is enabled. The biases are set via three flags, BIAS_DISABLE, BIAS_PULL_DOWN and BIAS_PULL_UP. These map directly to the similarly named pinctrl pin_config_param flags. As Is corresponds to none of the flags being set. The setting of biases on output lines may seem odd, but is to allow for utilisation of internal pull-up/pull-down on open drain and open source outputs, where supported in hardware. The series also adds the GPIOHANDLE_SET_CONFIG_IOCTL to the gpio chardev. The ioctl allows some of the configuration of a requested handle to be changed without having to release the line. The primary use case is the changing of direction for bi-directional lines. Patches are against Bart's gpio/for-next branch[1]. The patch has been successfully tested against gpio-mockup, and on a Raspberry Pi, in both cases using the feature/pud_set_config branch of my Go gpiod library[2], as well as with my feature/pud development branch of libgpiod[3]. Patch 7 has only been tested using my gpiod library as libgpiod has not yet been updated to support the SET_CONFIG ioctl. Patch 1 adds pull-up/pull-down support to line handle requests. Patch 2 adds pull-up/pull-down support to line event requests. Patch 3 adds support for disabling bias. Patch 4 adds support for setting bias on output lines. Patch 5 adds pull-up/down support to the gpio-mockup for uAPI testing. Patch 6 refactors the flag validation from linehandle_create. Patch 7 adds the SET_CONFIG ioctl. Drew Fustini (1): gpio: expose pull-up/pull-down line flags to userspace Kent Gibson (6): gpiolib: add support for pull up/down to lineevent_create gpiolib: add support for disabling line bias gpiolib: add support for biasing output lines gpio: mockup: add set_config to support pull up/down gpiolib: move validation of line handle flags into helper function gpio: add new SET_CONFIG ioctl() to gpio chardev drivers/gpio/gpio-mockup.c | 94 ++++++++++------ drivers/gpio/gpiolib.c | 213 +++++++++++++++++++++++++++++++------ drivers/gpio/gpiolib.h | 1 + include/uapi/linux/gpio.h | 24 +++++ 4 files changed, 264 insertions(+), 68 deletions(-)