| Message ID | 20190618160105.26343-1-alpawi@amazon.com |
|---|---|
| Headers | show |
| Series | pinctl: armada-37xx: fix for pins 32+ | expand |
On Tue, Jun 18, 2019 at 6:01 PM <alpawi@amazon.com> wrote: > From: Patrick Williams <alpawi@amazon.com> > > The 37xx GPIO config registers are only 32 bits long and > span 2 registers for the NB GPIO controller. The function > to calculate the offset was missing the increase to the > config register. > > I have tested both raw gpio access and interrupts using > libgpiod utilities on an Espressonbin. > > The first patch is a simple rename of a function because > the original name implied it was doing IO itself ("update > reg"). This patch could be dropped if undesired. > > The second patch contains the fix for GPIOs 32+. This looks good overall. I am waiting for a maintainer review. If nothing happens in a week, poke me and I'll just apply the patches. Yours, Linus Walleij
Hi, > On Tue, Jun 18, 2019 at 6:01 PM <alpawi@amazon.com> wrote: > >> From: Patrick Williams <alpawi@amazon.com> >> >> The 37xx GPIO config registers are only 32 bits long and >> span 2 registers for the NB GPIO controller. The function >> to calculate the offset was missing the increase to the >> config register. >> >> I have tested both raw gpio access and interrupts using >> libgpiod utilities on an Espressonbin. >> >> The first patch is a simple rename of a function because >> the original name implied it was doing IO itself ("update >> reg"). This patch could be dropped if undesired. >> >> The second patch contains the fix for GPIOs 32+. First you can add my Acked-by: Gregory CLEMENT <gregory.clement@bootlin.com> Then as the second patch is a fix, you should add the fix tag: "Fixes: 5715092a458c ("pinctrl: armada-37xx: Add gpio support") " as well as the 'CC: <stable@vger.kernel.org>" tags. But your change in the first patch made this second patch more difficult to backport. Actually, when I wrote "_update_reg" I was thinking to the update of the variable, whereas with a function named "_calculate_reg" I am expecting having the result as a return of the function. However I am not against your change, as I pointed my main concern is about the backport of the patch to the stable branch. Maybe you could change the order of those 2 patches? Thanks, Gregory > > This looks good overall. I am waiting for a maintainer review. > If nothing happens in a week, poke me and I'll just apply > the patches. > > Yours, > Linus Walleij > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
On Tue, Jun 25, 2019 at 03:38:59PM +0200, Gregory CLEMENT wrote: > First you can add my > Acked-by: Gregory CLEMENT <gregory.clement@bootlin.com> Thanks for the review Gregory. > Then as the second patch is a fix, you should add the fix tag: "Fixes: > 5715092a458c ("pinctrl: armada-37xx: Add gpio support") " as well as the > 'CC: <stable@vger.kernel.org>" tags. > > But your change in the first patch made this second patch more difficult > to backport. > ... > Maybe you could change the order of those 2 patches? Good points. Will do both. > Actually, when I wrote "_update_reg" I was thinking to the update of the > variable, whereas with a function named "_calculate_reg" I am expecting > having the result as a return of the function. Understand. I can see the ambiguity in both names. How about "_update_reg_offset"? > Thanks, > > Gregory >
From: Patrick Williams <alpawi@amazon.com> The 37xx GPIO config registers are only 32 bits long and span 2 registers for the NB GPIO controller. The function to calculate the offset was missing the increase to the config register. I have tested both raw gpio access and interrupts using libgpiod utilities on an Espressonbin. The first patch is a simple rename of a function because the original name implied it was doing IO itself ("update reg"). This patch could be dropped if undesired. The second patch contains the fix for GPIOs 32+. Patrick Williams (2): pinctrl: armada-37xx: rename reg-offset function pinctrl: armada-37xx: fix control of pins 32 and up drivers/pinctrl/mvebu/pinctrl-armada-37xx.c | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-)