mbox series

[0/3] qcom: spmi: add support for hierarchical IRQ chip

Message ID 20181229114755.8711-1-masneyb@onstation.org
Headers show
Series qcom: spmi: add support for hierarchical IRQ chip | expand

Message

Brian Masney Dec. 29, 2018, 11:47 a.m. UTC
This patch series adds hierarchical IRQ chip support to spmi-gpio so
that device tree consumers can request an IRQ directly from the GPIO
block rather than having to request an IRQ from the underlying PMIC.
The first patch in this series converts pmic-arb to use the version 2
IRQ interface and patches 2 and 3 add support for the hierarchical
IRQ chip to spmi-gpio.

For more background information, see the email thread with Linus
Walleij's excellent description of the problem at
https://www.spinics.net/lists/linux-gpio/msg34655.html.

The patches need to be applied in the order that I have them in order
to allow for a proper bisection, however part of the series can be
applied without any breakage. Maybe the spmi-arb change can go in
for v4.21 and the spmi-gpio changes can go in for v4.22?

This work was tested on a LG Nexus 5 (hammerhead) phone. My status page
at https://masneyb.github.io/nexus-5-upstream/ describes what is working
so far with an upstream kernel.

Brian Masney (3):
  spmi: pmic-arb: convert to v2 irq interfaces to support hierarchical
    IRQ chips
  qcom: spmi-gpio: add support for hierarchical IRQ chip
  ARM: dts: qcom: msm8974: add interrupt properties

 arch/arm/boot/dts/qcom-pm8941.dtsi       |   3 +
 drivers/pinctrl/qcom/pinctrl-spmi-gpio.c | 119 ++++++++++++++++++++++-
 drivers/spmi/spmi-pmic-arb.c             |  91 ++++++++++++-----
 3 files changed, 182 insertions(+), 31 deletions(-)

Comments

Linus Walleij Dec. 30, 2018, 8:11 p.m. UTC | #1
On Sat, Dec 29, 2018 at 12:48 PM Brian Masney <masneyb@onstation.org> wrote:

> This patch series adds hierarchical IRQ chip support to spmi-gpio so
> that device tree consumers can request an IRQ directly from the GPIO
> block rather than having to request an IRQ from the underlying PMIC.
> The first patch in this series converts pmic-arb to use the version 2
> IRQ interface and patches 2 and 3 add support for the hierarchical
> IRQ chip to spmi-gpio.

Very nice stuff!

> The patches need to be applied in the order that I have them in order
> to allow for a proper bisection, however part of the series can be
> applied without any breakage. Maybe the spmi-arb change can go in
> for v4.21 and the spmi-gpio changes can go in for v4.22?

I'm fairly sure the SPMI maintainer (Stephen Boyd) can just ACK the
patch once he's happy with it and I can then apply it all to
the pin control tree.

> This work was tested on a LG Nexus 5 (hammerhead) phone. My status page
> at https://masneyb.github.io/nexus-5-upstream/ describes what is working
> so far with an upstream kernel.

I'm a big fan of your work. I have a few of these devices as well,
so the day I manage to create a serial cable for it, I'll gladly test
this stuff and see what I can add.

Yours,
Linus Walleij