mbox series

[LINUX,V3,0/9] gpio-xilinx: Update on xilinx gpio driver

Message ID 1605201148-4508-1-git-send-email-srinivas.neeli@xilinx.com
Headers show
Series gpio-xilinx: Update on xilinx gpio driver | expand

Message

Srinivas Neeli Nov. 12, 2020, 5:12 p.m. UTC
This patch series does the following:
-Add clock support
-Add interrupt support
-Add support for suspend and resume
-Add remove support
-Add MAINTAINERS fragment
---
Changes in V3:
-Created separate patch to arrange headers in sorting order.
-Updated dt-bindings.
-Created separate patch for Clock changes and runtime resume.
 and suspend.
-Created separate patch for spinlock changes.
-Created separate patch for remove support.
-Fixed coverity errors.
-Updated minor review comments.

Changes in V2:
-Added check for return value of platform_get_irq() API.
-Updated code to support rising edge and falling edge.
-Added xgpio_xlate() API to support switch.
-Added MAINTAINERS fragment.

Tested Below scenarios:
-Tested Loop Back.(channel 1.0 connected to channel 2.0)
-Tested External switch(Used DIP switch)
-Tested Cascade scenario(Here gpio controller acting as
 an interrupt controller).
---

Srinivas Neeli (9):
  gpio: gpio-xilinx: Arrange headers in sorting order
  dt-bindings: gpio: gpio-xilinx: Add clk support to xilinx soft gpio IP
  gpio: gpio-xilinx: Add clock support
  gpio: gpio-xilinx: Reduce spinlock array to single
  gpio: gpio-xilinx: Add interrupt support
  gpio: gpio-xilinx: Add remove function
  gpio: gpio-xilinx: Add support for suspend and resume
  gpio: gpio-xilinx: Check return value of of_property_read_u32
  MAINTAINERS: add fragment for xilinx GPIO drivers

 .../devicetree/bindings/gpio/gpio-xilinx.txt       |   2 +
 MAINTAINERS                                        |  10 +
 drivers/gpio/Kconfig                               |   2 +
 drivers/gpio/gpio-xilinx.c                         | 398 +++++++++++++++++++--
 4 files changed, 390 insertions(+), 22 deletions(-)

Comments

Michal Simek Nov. 13, 2020, 7:44 a.m. UTC | #1
On 12. 11. 20 18:12, Srinivas Neeli wrote:
> This patch series does the following:
> -Add clock support
> -Add interrupt support
> -Add support for suspend and resume
> -Add remove support
> -Add MAINTAINERS fragment
> ---
> Changes in V3:
> -Created separate patch to arrange headers in sorting order.
> -Updated dt-bindings.
> -Created separate patch for Clock changes and runtime resume.
>  and suspend.
> -Created separate patch for spinlock changes.
> -Created separate patch for remove support.
> -Fixed coverity errors.
> -Updated minor review comments.
> 
> Changes in V2:
> -Added check for return value of platform_get_irq() API.
> -Updated code to support rising edge and falling edge.
> -Added xgpio_xlate() API to support switch.
> -Added MAINTAINERS fragment.
> 
> Tested Below scenarios:
> -Tested Loop Back.(channel 1.0 connected to channel 2.0)
> -Tested External switch(Used DIP switch)
> -Tested Cascade scenario(Here gpio controller acting as
>  an interrupt controller).
> ---
> 
> Srinivas Neeli (9):
>   gpio: gpio-xilinx: Arrange headers in sorting order
>   dt-bindings: gpio: gpio-xilinx: Add clk support to xilinx soft gpio IP
>   gpio: gpio-xilinx: Add clock support
>   gpio: gpio-xilinx: Reduce spinlock array to single
>   gpio: gpio-xilinx: Add interrupt support
>   gpio: gpio-xilinx: Add remove function
>   gpio: gpio-xilinx: Add support for suspend and resume
>   gpio: gpio-xilinx: Check return value of of_property_read_u32
>   MAINTAINERS: add fragment for xilinx GPIO drivers
> 
>  .../devicetree/bindings/gpio/gpio-xilinx.txt       |   2 +
>  MAINTAINERS                                        |  10 +
>  drivers/gpio/Kconfig                               |   2 +
>  drivers/gpio/gpio-xilinx.c                         | 398 +++++++++++++++++++--
>  4 files changed, 390 insertions(+), 22 deletions(-)
> 

For the whole series.
Acked-by: Michal Simek <michal.simek@xilinx.com>

Thanks,
Michal
Linus Walleij Nov. 18, 2020, 12:42 a.m. UTC | #2
On Thu, Nov 12, 2020 at 6:13 PM Srinivas Neeli
<srinivas.neeli@xilinx.com> wrote:

> Srinivas Neeli (9):

>   gpio: gpio-xilinx: Arrange headers in sorting order
>   dt-bindings: gpio: gpio-xilinx: Add clk support to xilinx soft gpio IP
>   gpio: gpio-xilinx: Add clock support
>   gpio: gpio-xilinx: Reduce spinlock array to single
>   gpio: gpio-xilinx: Add interrupt support
>   gpio: gpio-xilinx: Add remove function
>   gpio: gpio-xilinx: Add support for suspend and resume
>   gpio: gpio-xilinx: Check return value of of_property_read_u32
>   MAINTAINERS: add fragment for xilinx GPIO drivers

So I applied patches 1, 2, 3, 6, 8, 9 now so you can
focus on developing and resending the remaining patches.

Yours,
Linus Walleij
Srinivas Neeli Nov. 19, 2020, 5:29 a.m. UTC | #3
Hi Linus,

> -----Original Message-----
> From: Linus Walleij <linus.walleij@linaro.org>
> Sent: Wednesday, November 18, 2020 6:12 AM
> To: Srinivas Neeli <sneeli@xilinx.com>
> Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>; Michal Simek
> <michals@xilinx.com>; Shubhrajyoti Datta <shubhraj@xilinx.com>; Srinivas
> Goud <sgoud@xilinx.com>; Robert Hancock <hancock@sedsystems.ca>;
> open list:GPIO SUBSYSTEM <linux-gpio@vger.kernel.org>; Linux ARM <linux-
> arm-kernel@lists.infradead.org>; linux-kernel@vger.kernel.org; git
> <git@xilinx.com>
> Subject: Re: [LINUX PATCH V3 0/9] gpio-xilinx: Update on xilinx gpio driver
> 
> On Thu, Nov 12, 2020 at 6:13 PM Srinivas Neeli <srinivas.neeli@xilinx.com>
> wrote:
> 
> > Srinivas Neeli (9):
> 
> >   gpio: gpio-xilinx: Arrange headers in sorting order
> >   dt-bindings: gpio: gpio-xilinx: Add clk support to xilinx soft gpio IP
> >   gpio: gpio-xilinx: Add clock support
> >   gpio: gpio-xilinx: Reduce spinlock array to single
> >   gpio: gpio-xilinx: Add interrupt support
> >   gpio: gpio-xilinx: Add remove function
> >   gpio: gpio-xilinx: Add support for suspend and resume
> >   gpio: gpio-xilinx: Check return value of of_property_read_u32
> >   MAINTAINERS: add fragment for xilinx GPIO drivers
> 
> So I applied patches 1, 2, 3, 6, 8, 9 now so you can focus on developing and
> resending the remaining patches.

Will address remaining patches in V4 series.
> 
> Yours,
> Linus Walleij