diff mbox series

[1/5] dt-bindings: fsi: Document gpios

Message ID 20200728025527.174503-2-joel@jms.id.au
State New
Headers show
Series fsi: Support extra functions on ASPEED master | expand

Commit Message

Joel Stanley July 28, 2020, 2:55 a.m. UTC
The FSI master has some associated GPIOs that may be present on some
hardware configurations.

Signed-off-by: Joel Stanley <joel@jms.id.au>
---
 .../devicetree/bindings/fsi/fsi-master-aspeed.txt    | 12 ++++++++++++
 1 file changed, 12 insertions(+)

Comments

Andrew Jeffery Sept. 3, 2020, 4:42 a.m. UTC | #1
On Tue, 28 Jul 2020, at 12:25, Joel Stanley wrote:
> The FSI master has some associated GPIOs that may be present on some
> hardware configurations.
> 
> Signed-off-by: Joel Stanley <joel@jms.id.au>
> ---
>  .../devicetree/bindings/fsi/fsi-master-aspeed.txt    | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git 
> a/Documentation/devicetree/bindings/fsi/fsi-master-aspeed.txt 
> b/Documentation/devicetree/bindings/fsi/fsi-master-aspeed.txt
> index b758f91914f7..a513e65ec0c9 100644
> --- a/Documentation/devicetree/bindings/fsi/fsi-master-aspeed.txt
> +++ b/Documentation/devicetree/bindings/fsi/fsi-master-aspeed.txt
> @@ -12,6 +12,13 @@ Required properties:
>   - pinctrl-0: phandle to pinctrl node
>   - pinctrl-names: pinctrl state
>  
> +Optional properties:
> + - cfam-reset-gpios: GPIO for CFAM reset
> +
> + - fsi-routing-gpios: GPIO for setting the FSI mux (internal or cabled)
> + - fsi-mux-gpios: GPIO for detecting the desired FSI mux state
> +
> +

Is the double-linebreak intentional? Anyway:

Reviewed-by: Andrew Jeffery <andrew@aj.id.au>

>  Examples:
>  
>      fsi-master {
> @@ -21,4 +28,9 @@ Examples:
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&pinctrl_fsi1_default>;
>  	clocks = <&syscon ASPEED_CLK_GATE_FSICLK>;
> +
> +	fsi-routing-gpios = <&gpio0 ASPEED_GPIO(Q, 7) GPIO_ACTIVE_HIGH>;
> +	fsi-mux-gpios = <&gpio0 ASPEED_GPIO(B, 0) GPIO_ACTIVE_HIGH>;
> +
> +	cfam-reset-gpios = <&gpio0 ASPEED_GPIO(Q, 0) GPIO_ACTIVE_LOW>;
>      };
> -- 
> 2.27.0
> 
>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/fsi/fsi-master-aspeed.txt b/Documentation/devicetree/bindings/fsi/fsi-master-aspeed.txt
index b758f91914f7..a513e65ec0c9 100644
--- a/Documentation/devicetree/bindings/fsi/fsi-master-aspeed.txt
+++ b/Documentation/devicetree/bindings/fsi/fsi-master-aspeed.txt
@@ -12,6 +12,13 @@  Required properties:
  - pinctrl-0: phandle to pinctrl node
  - pinctrl-names: pinctrl state
 
+Optional properties:
+ - cfam-reset-gpios: GPIO for CFAM reset
+
+ - fsi-routing-gpios: GPIO for setting the FSI mux (internal or cabled)
+ - fsi-mux-gpios: GPIO for detecting the desired FSI mux state
+
+
 Examples:
 
     fsi-master {
@@ -21,4 +28,9 @@  Examples:
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_fsi1_default>;
 	clocks = <&syscon ASPEED_CLK_GATE_FSICLK>;
+
+	fsi-routing-gpios = <&gpio0 ASPEED_GPIO(Q, 7) GPIO_ACTIVE_HIGH>;
+	fsi-mux-gpios = <&gpio0 ASPEED_GPIO(B, 0) GPIO_ACTIVE_HIGH>;
+
+	cfam-reset-gpios = <&gpio0 ASPEED_GPIO(Q, 0) GPIO_ACTIVE_LOW>;
     };