| Message ID | de9191d6-1cb1-6725-f378-b886c9cd06d0@virtuozzo.com |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | ext4: number of long lived errors | expand |
On Wed, Oct 31, 2018 at 12:57:45AM +0300, Vasily Averin wrote: > Fixes 33afdcc5402d ("ext4: add a function which sets up group blocks ...") # 3.3 > > Signed-off-by: Vasily Averin <vvs@virtuozzo.com> Thanks, applied. I adjusted the patch summary: ext4: add missing brelse() in set_flexbg_block_bitmap()'s error path Also please note that properly Fixes should have a colon, and to add Cc: stable@kernel.org to trailer to make sure they get backported: Fixes: 33afdcc5402d ("ext4: add a function which sets up group blocks ...") Cc: stable@kernel.org # 3.3 - Ted
diff --git a/fs/ext4/resize.c b/fs/ext4/resize.c index c3fa30878ca8..0a4dc6217e78 100644 --- a/fs/ext4/resize.c +++ b/fs/ext4/resize.c @@ -459,16 +459,18 @@ static int set_flexbg_block_bitmap(struct super_block *sb, handle_t *handle, BUFFER_TRACE(bh, "get_write_access"); err = ext4_journal_get_write_access(handle, bh); - if (err) + if (err) { + brelse(bh); return err; + } ext4_debug("mark block bitmap %#04llx (+%llu/%u)\n", first_cluster, first_cluster - start, count2); ext4_set_bits(bh->b_data, first_cluster - start, count2); err = ext4_handle_dirty_metadata(handle, NULL, bh); + brelse(bh); if (unlikely(err)) return err; - brelse(bh); } return 0;
Fixes 33afdcc5402d ("ext4: add a function which sets up group blocks ...") # 3.3 Signed-off-by: Vasily Averin <vvs@virtuozzo.com> --- fs/ext4/resize.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)