| Message ID | c49faf0c-d5d5-9c51-6911-9e0ff57c6bfa@gmail.com |
|---|---|
| State | Awaiting Upstream |
| Headers | show |
| Series | ext4: delete invalid comments near ext4_mb_check_limits() | expand |
On 8/7/20 7:31 PM, brookxu wrote: > These comments do not seem to be related to ext4_mb_check_limits(), > it may be invalid. > > Signed-off-by: Chunguang Xu <brookxu@tencent.com> Either ways these comments are of no help and the function has enough comments within. So we should be good without it. Reviewed-by: Ritesh Harjani <riteshh@linux.ibm.com> > --- > fs/ext4/mballoc.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c > index 577ce98..aaefeb4 100644 > --- a/fs/ext4/mballoc.c > +++ b/fs/ext4/mballoc.c > @@ -1743,10 +1743,6 @@ static void ext4_mb_use_best_found(struct ext4_allocation_context *ac, > > } > > -/* > - * regular allocator, for general purposes allocation > - */ > - > static void ext4_mb_check_limits(struct ext4_allocation_context *ac, > struct ext4_buddy *e4b, > int finish_group) >
On Fri, Aug 07, 2020 at 10:01:33PM +0800, brookxu wrote: > These comments do not seem to be related to ext4_mb_check_limits(), > it may be invalid. > > Signed-off-by: Chunguang Xu <brookxu@tencent.com> Thanks, applied. - Ted
diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c index 577ce98..aaefeb4 100644 --- a/fs/ext4/mballoc.c +++ b/fs/ext4/mballoc.c @@ -1743,10 +1743,6 @@ static void ext4_mb_use_best_found(struct ext4_allocation_context *ac, } -/* - * regular allocator, for general purposes allocation - */ - static void ext4_mb_check_limits(struct ext4_allocation_context *ac, struct ext4_buddy *e4b, int finish_group)
These comments do not seem to be related to ext4_mb_check_limits(), it may be invalid. Signed-off-by: Chunguang Xu <brookxu@tencent.com> --- fs/ext4/mballoc.c | 4 ---- 1 file changed, 4 deletions(-)