diff mbox series

ext4: add comment for ext4_dir_entry_2 file_type member

Message ID ad3290d5-86af-99c1-f9d5-cd1bab710429@jguk.org
State New
Headers show
Series ext4: add comment for ext4_dir_entry_2 file_type member | expand

Commit Message

Jonny Grant May 22, 2020, 3:09 p.m. UTC
From 4e9d768a0adb60698ba13e7b7522c15a4548332a Mon Sep 17 00:00:00 2001
From: Jonathan Grant <jg@jguk.org>
Date: Fri, 22 May 2020 16:07:58 +0100
Subject: [PATCH] add comment for ext4_dir_entry_2 file_type member

Signed-off-by: Jonathan Grant <jg@jguk.org>
---
  fs/ext4/ext4.h | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Andreas Dilger May 23, 2020, 5:12 a.m. UTC | #1
On May 22, 2020, at 9:09 AM, Jonny Grant <jg@jguk.org> wrote:
> 
> From 4e9d768a0adb60698ba13e7b7522c15a4548332a Mon Sep 17 00:00:00 2001
> From: Jonathan Grant <jg@jguk.org>
> Date: Fri, 22 May 2020 16:07:58 +0100
> Subject: [PATCH] add comment for ext4_dir_entry_2 file_type member
> 
> Signed-off-by: Jonathan Grant <jg@jguk.org>

Reviewed-by: Andreas Dilger <adilger@dilger.ca>

> ---
> fs/ext4/ext4.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
> index ad2dbf6e4924..7a042896bab7 100644
> --- a/fs/ext4/ext4.h
> +++ b/fs/ext4/ext4.h
> @@ -2050,7 +2050,7 @@ struct ext4_dir_entry_2 {
> 	__le32	inode;			/* Inode number */
> 	__le16	rec_len;		/* Directory entry length */
> 	__u8	name_len;		/* Name length */
> -	__u8	file_type;
> +	__u8	file_type;		/* See file type macros EXT4_FT_* below */
> 	char	name[EXT4_NAME_LEN];	/* File name */
> };
> 
> --
> 2.17.1
> 


Cheers, Andreas
diff mbox series

Patch

diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
index ad2dbf6e4924..7a042896bab7 100644
--- a/fs/ext4/ext4.h
+++ b/fs/ext4/ext4.h
@@ -2050,7 +2050,7 @@  struct ext4_dir_entry_2 {
  	__le32	inode;			/* Inode number */
  	__le16	rec_len;		/* Directory entry length */
  	__u8	name_len;		/* Name length */
-	__u8	file_type;
+	__u8	file_type;		/* See file type macros EXT4_FT_* below */
  	char	name[EXT4_NAME_LEN];	/* File name */
  };