[4/3] buffer: Use bdev_getblk() in __breadahead()

Message ID	ZNaKoWbYyOveesVc@casper.infradead.org
State	Not Applicable
Headers	show Return-Path: <SRS0=FzWX=D4=vger.kernel.org=linux-ext4-owner@ozlabs.org> Date: Fri, 11 Aug 2023 20:23:13 +0100 From: Matthew Wilcox <willy@infradead.org> To: akpm@linux-foundation.org Cc: Hui Zhu <teawater@antgroup.com>, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org Subject: [PATCH 4/3] buffer: Use bdev_getblk() in __breadahead() Message-ID: <ZNaKoWbYyOveesVc@casper.infradead.org> References: <20230811161528.506437-1-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230811161528.506437-1-willy@infradead.org> Precedence: bulk
Series	Add and use bdev_getblk() \| expand [0/3] Add and use bdev_getblk() [1/3] buffer: Pass GFP flags to folio_alloc_buffers() [2/3] buffer: Hoist GFP flags from grow_dev_page() to __getblk_gfp() [3/3] ext4: Use bdev_getblk() to avoid memory reclaim in readahead path [4/3] buffer: Use bdev_getblk() in __breadahead()

Message ID

ZNaKoWbYyOveesVc@casper.infradead.org

State

Not Applicable

Headers

Date: Fri, 11 Aug 2023 20:23:13 +0100
From: Matthew Wilcox <willy@infradead.org>
To: akpm@linux-foundation.org
Cc: Hui Zhu <teawater@antgroup.com>, linux-fsdevel@vger.kernel.org,
        linux-ext4@vger.kernel.org
Subject: [PATCH 4/3] buffer: Use bdev_getblk() in __breadahead()
Message-ID: <ZNaKoWbYyOveesVc@casper.infradead.org>
References: <20230811161528.506437-1-willy@infradead.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230811161528.506437-1-willy@infradead.org>
Precedence: bulk

Series

Add and use bdev_getblk() | expand

Commit Message

Matthew Wilcox Aug. 11, 2023, 7:23 p.m. UTC

It occurs to me that this would also be useful and I'll include it in
the next version:

diff --git a/fs/buffer.c b/fs/buffer.c
index 122b7d16befb..b551a5b1196b 100644
--- a/fs/buffer.c
+++ b/fs/buffer.c
@@ -1470,7 +1470,9 @@  EXPORT_SYMBOL(__getblk_gfp);
  */
 void __breadahead(struct block_device *bdev, sector_t block, unsigned size)
 {
-       struct buffer_head *bh = __getblk(bdev, block, size);
+       struct buffer_head *bh = bdev_getblk(bdev, block, size,
+                       GFP_NOWAIT | __GFP_MOVABLE | __GFP_ACCOUNT);
+
        if (likely(bh)) {
                bh_readahead(bh, REQ_RAHEAD);
                brelse(bh);

[4/3] buffer: Use bdev_getblk() in __breadahead()

Commit Message

Patch