From patchwork Fri Mar 27 10:36:49 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Carpenter X-Patchwork-Id: 25224 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id 1AC04DDF09 for ; Fri, 27 Mar 2009 21:39:26 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754689AbZC0KjT (ORCPT ); Fri, 27 Mar 2009 06:39:19 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754785AbZC0KjT (ORCPT ); Fri, 27 Mar 2009 06:39:19 -0400 Received: from fg-out-1718.google.com ([72.14.220.155]:29210 "EHLO fg-out-1718.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754689AbZC0KjS (ORCPT ); Fri, 27 Mar 2009 06:39:18 -0400 Received: by fg-out-1718.google.com with SMTP id 16so8047fgg.17 for ; Fri, 27 Mar 2009 03:39:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:date:from:x-x-sender:to:cc :subject:message-id:mime-version:content-type; bh=corKsfolXTVhzRBkbL+g74felzCip3UiFx6C76fnEt4=; b=saurYYs2R+NP1QJ2BCCKEzhTSFuj2JJ7Xp9Ei0CqaI0ZYBftxLJoFDKyf3MEKT1NtG DN2i50qONqtMkO0ZYpeS2bR/tT668/Dhq+uwTbSR4r1qiIJRHQ3L3XpqfHjNRID3P4JI NabB+Uyr/TQ1ST8fimyGv7IT1fWdnpAQ+PWpg= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:x-x-sender:to:cc:subject:message-id:mime-version :content-type; b=Rpa25upV6m37IGYN97GM4UfoVhnhYWjmfSF7DxSQd1yEAfpoPTM31Eb1oZCCoL+UYU IQ8UECL8d++GkLdUfwClNCDTsOAGrRjVbd3iRqRUxD7nm7kklbAujfnukU+znVOYWB95 V3fIR7ynvUwJkSSe5kJpWEd27azDW/je/fxbg= Received: by 10.86.3.4 with SMTP id 4mr1976694fgc.66.1238150356045; Fri, 27 Mar 2009 03:39:16 -0700 (PDT) Received: from ?192.168.1.118? ([196.201.134.157]) by mx.google.com with ESMTPS id 4sm66559fge.18.2009.03.27.03.39.06 (version=TLSv1/SSLv3 cipher=RC4-MD5); Fri, 27 Mar 2009 03:39:15 -0700 (PDT) Date: Fri, 27 Mar 2009 13:36:49 +0300 (EAT) From: Dan Carpenter X-X-Sender: dcarpenter@usbsys.site To: tytso@mit.edu, adilger@sun.com cc: linux-ext4@vger.kernel.org Subject: [patch] ext4: typo leads to small leak Message-ID: MIME-Version: 1.0 Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org This was found by smatch (http://repo.or.cz/w/smatch.git/) regards, dan carpenter Signed-off-by: Dan Carpenter Reviewed-by: Eric Sandeen --- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- orig/fs/ext4/mballoc.c 2009-03-26 18:22:30.000000000 +0300 +++ devel/fs/ext4/mballoc.c 2009-03-26 18:22:56.000000000 +0300 @@ -2693,7 +2693,7 @@ i = (sb->s_blocksize_bits + 2) * sizeof(unsigned int); sbi->s_mb_maxs = kmalloc(i, GFP_KERNEL); if (sbi->s_mb_maxs == NULL) { - kfree(sbi->s_mb_maxs); + kfree(sbi->s_mb_offsets); return -ENOMEM; }