| Message ID | CAOjcEBJ10SNdHwHH8mHxF5r3Zvz--UF8H7gdiv7T07T7y9=JuA@mail.gmail.com |
|---|---|
| State | New, archived |
| Headers | show |
On Sun, Nov 01, 2015 at 11:23:20AM -0500, Xu Cang wrote:
> to fix sparse warning, add static to ext4_seq_##name##_fops struct.
This is a good patch, but it's missing a Signed-off-by tag.
Please take a look at the directions in the
Documentation/SubmittingPatches file.
Many thanks,
- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/fs/ext4/sysfs.c b/fs/ext4/sysfs.c index 1b57c72..1420a3c 100644 --- a/fs/ext4/sysfs.c +++ b/fs/ext4/sysfs.c @@ -358,7 +358,7 @@ static int name##_open(struct inode *inode, struct file *file) \ return single_open(file, ext4_seq_##name##_show, PDE_DATA(inode)); \ } \ \ -const struct file_operations ext4_seq_##name##_fops = { \ +static const struct file_operations ext4_seq_##name##_fops = { \ .owner = THIS_MODULE, \ .open = name##_open, \
to fix sparse warning, add static to ext4_seq_##name##_fops struct. .read = seq_read, \ -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html