Message ID | BANLkTinBL5GbhUg5NLCqmLEfz0nNFrjf-w@mail.gmail.com |
---|---|
State | Not Applicable, archived |
Headers | show |
On Thu, 2 Jun 2011, Amir G. wrote: --snip-- > > Ted actually brought this up in our ext4 developers meeting on LSF. > He said we could register an ext4 module with the ext4dev external symbols > and it would be useful for testing, since we already have all those tools that > are aware of ext4dev. I know, but my point is still valid. why to introduce non-existing FSTYP into other tools, this is not proper course of action. If the goal is really resurrect ext4dev we should do this first. > > I am still using a more low-tech method of cloning ext4 (sed) to build > a standalone ext4dev module for testing, but it's the same principle. > > >> > >> --snip-- > >> > >> So, yes, it's true. There are other ways to accomplish what I am doing, > >> but I am going out of my way to try to make the life of developers and testers > >> easier and you are doing the exact opposite by raising objections to a rather > >> trivial and harmless patch. > > > > What is easier for testers and developers ? I fail to see the reason for > > including non-existing FSTYP into xfstests while it should be forgotten > > by now. Just provide sources with whatever fs name you choose (or just > > patches for ext4 preferably), provide patches to e2fsprogs and patches to > > xfstests if you want people to test with it. And it should be easy for every > > tester, or developer to use it, shouldn't it ? Is that a problem ? > > Yes, it is a problem. You are thinking in terms of a developer who builds > new kernels on a daily basis. > Back in the time, when I developed next3, I asked some friend and > people in the community > if they could test it. > It turned out that they don't even know how to build a kernel and they > don't want > to invest the time in doing that. > This is when I realized that to get to a wider audience of testers, I > need to make the testing > process E A S Y ! > > And by E A S Y, I mean: > 1. Take a Fedora 15 system > 2. download http://next3.sourceforge.net/files/1.0.13/ext4dev_snapshots-1.0.13-x86_64.tar.gz > 3. tar xfz ext4dev_snapshots-1.0.13-x86_64.tar.gz && cd ext4dev_snapshots-1.0.13 > 4. make && sudo make install && sudo make test So you're saying that you can not patch xfstests (and other) sources in the make time ?? Thanks! -Lukas -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/common.defrag b/common.defrag index 1bcf01d..4850803 100644 --- a/common.defrag +++ b/common.defrag @@ -26,7 +26,7 @@ _require_defrag() xfs) DEFRAG_PROG=/usr/sbin/xfs_fsr ;; - ext4) + ext4|ext4dev) DEFRAG_PROG=/usr/bin/e4defrag ;; *) diff --git a/common.quota b/common.quota index 3c87ce1..9736306 100644 --- a/common.quota +++ b/common.quota @@ -29,7 +29,7 @@ _require_quota() [ -n $QUOTA_PROG ] || _notrun "Quota user tools not installed" case $FSTYP in - ext2|ext3|ext4|reiserfs) + ext2|ext3|ext4|ext4dev|reiserfs) if [ ! -d /proc/sys/fs/quota ]; then _notrun "Installed kernel does not support quotas" fi @@ -237,10 +237,14 @@ _check_quota_usage() # Sync to get delalloc to disk sync VFS_QUOTA=0 - if [ $FSTYP = "ext2" -o $FSTYP = "ext3" -o $FSTYP = "ext4" -o $FSTYP = "reiserfs" ]; then + case $FSTYP in + ext2|ext3|ext4|ext4dev|reiserfs) VFS_QUOTA=1 quotaon -f -u -g $SCRATCH_MNT 2>/dev/null - fi + ;; + *) + ;; + esac repquota -u -n $SCRATCH_MNT | grep -v "^#0" | _filter_scratch | sort >$tmp.user.orig repquota -g -n $SCRATCH_MNT | grep -v "^#0" | _filter_scratch | diff --git a/common.rc b/common.rc index e634fbb..c510c66 100644 --- a/common.rc +++ b/common.rc @@ -65,7 +65,7 @@ _mount_opts() nfs) export MOUNT_OPTIONS=$NFS_MOUNT_OPTIONS ;; - ext2|ext3|ext4) + ext2|ext3|ext4|ext4dev) # acls & xattrs aren't turned on by default on ext$FOO export MOUNT_OPTIONS="-o acl,user_xattr $EXT_MOUNT_OPTIONS" ;; @@ -110,7 +110,7 @@ _mkfs_opts() _fsck_opts() { case $FSTYP in - ext2|ext3|ext4) + ext2|ext3|ext4|ext4dev) export FSCK_OPTIONS="-nf" ;; reiserfs) @@ -326,10 +326,10 @@ _scratch_mkfs_sized() xfs) _scratch_mkfs_xfs -d size=$fssize -b size=$blocksize ;; - ext2|ext3|ext4) + ext2|ext3|ext4|ext4dev) /sbin/mkfs.$FSTYP $MKFS_OPTIONS -b $blocksize $SCRATCH_DEV $blocks ;; - btrfs) + btrfs) /sbin/mkfs.$FSTYP $MKFS_OPTIONS $SCRATCH_DEV -b $fssize ;; *) @@ -354,7 +354,7 @@ _scratch_mkfs_geom() xfs) MKFS_OPTIONS+=" -b size=$blocksize, -d su=$sunit_bytes,sw=$swidth_mult" ;; - ext4) + ext4|ext4dev) MKFS_OPTIONS+=" -b $blocksize -E stride=$sunit_blocks,stripe_width=$swidth_blocks" ;;