diff mbox

xfstests ext4/304 failing due to donor inode's i_size == 0

Message ID 87h9llior0.fsf@openvz.org
State Accepted, archived
Headers show

Commit Message

Dmitry Monakhov Oct. 20, 2015, 2:44 p.m. UTC
Theodore Ts'o <tytso@mit.edu> writes:

> Hi Dmitry,
>
> I was investigating why ext4/304 is failing, and it's due to
> defrag-fuzzer returning an error:
Yep. You are right. I have out of tree patch which fix that. I'll send it
to xfstests-dev list.

Comments

Theodore Ts'o Oct. 25, 2015, 11:10 a.m. UTC | #1
On Tue, Oct 20, 2015 at 05:44:03PM +0300, Dmitry Monakhov wrote:
> Theodore Ts'o <tytso@mit.edu> writes:
> 
> > Hi Dmitry,
> >
> > I was investigating why ext4/304 is failing, and it's due to
> > defrag-fuzzer returning an error:
> Yep. You are right. I have out of tree patch which fix that. I'll send it
> to xfstests-dev list.

I tried the patch you sent, but ext4/304 is still failing.  At the end
of 304.full:

fio: file hash not empty on exit

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

From ee628504370564704e218ecf089f00c243b6fd12 Mon Sep 17 00:00:00 2001
From: Dmitry Monakhov <dmonakhov@openvz.org>
Date: Tue, 20 Oct 2015 18:32:03 +0400
Subject: [PATCH] ext4/304 handle ENOSPC/EINVAL correctly

'defrag-fuzzer' is  task which  try to perform inplace defrag, inline-defrag
is basically  of {falloc,ioc_swap} and may fail due to ENOSPC on first stage.
In that case IOCTL returns EINVAL (because we try to swap invalid extents)

Since this is hard core test then ENOSPC and corresponding EINVAL is expected.

Signed-off-by: Dmitry Monakhov <dmonakhov@openvz.org>
---
 tests/ext4/304 |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/tests/ext4/304 b/tests/ext4/304
index 7b90f1d..81d69b8 100644
--- a/tests/ext4/304
+++ b/tests/ext4/304
@@ -76,6 +76,7 @@  donorname=test4.def
 filename=test4
 inplace=1
 rw=randwrite
+ignore_error=,EINVAL
 numjobs=4*${LOAD_FACTOR}
 runtime=30*${TIME_FACTOR}
 time_based
-- 
1.7.1