diff mbox series

[6/6] lib/ext2fs: call ext2fs_free_mem() to free &io->name in exception branch

Message ID 7bd86fda-90f1-601f-05b2-b247b5dd6bed@huawei.com
State Superseded
Headers show
Series solve memory leak and check whether NULL pointer | expand

Commit Message

zhanchengbin Dec. 3, 2021, 6:31 a.m. UTC 
In the exception branch,if we donot call ext2fs_free_mem() to
free &io->name, memory leak will occur.

Signed-off-by: zhanchengbin <zhanchengbin1@huawei.com>
Signed-off-by: Zhiqiang Liu <liuzhiqiang26@huawei.com>
---
  lib/ext2fs/test_io.c | 2 ++
  lib/ext2fs/undo_io.c | 2 ++
  2 files changed, 4 insertions(+)
diff mbox series

Patch

diff --git a/lib/ext2fs/test_io.c b/lib/ext2fs/test_io.c
index 480e68fc..6843edbc 100644
--- a/lib/ext2fs/test_io.c
+++ b/lib/ext2fs/test_io.c
@@ -248,6 +248,8 @@  static errcode_t test_open(const char *name, int 
flags, io_channel *channel)
      return 0;

  cleanup:
+    if (io && io->name)
+        ext2fs_free_mem(&io->name);
      if (io)
          ext2fs_free_mem(&io);
      if (data)
diff --git a/lib/ext2fs/undo_io.c b/lib/ext2fs/undo_io.c
index eb56f53d..0d4915cb 100644
--- a/lib/ext2fs/undo_io.c
+++ b/lib/ext2fs/undo_io.c
@@ -788,6 +788,8 @@  cleanup:
          free(data->tdb_file);
      if (data && data->real)
          io_channel_close(data->real);
+    if (io && io->name)
+        ext2fs_free_mem(&io->name);
      if (data)
          ext2fs_free_mem(&data);
      if (io)