From patchwork Fri Aug 23 00:03:23 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Lutomirski X-Patchwork-Id: 269233 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id AF0FE2C0085 for ; Fri, 23 Aug 2013 10:04:10 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754602Ab3HWAD5 (ORCPT ); Thu, 22 Aug 2013 20:03:57 -0400 Received: from mail-pd0-f172.google.com ([209.85.192.172]:51796 "EHLO mail-pd0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754723Ab3HWADx (ORCPT ); Thu, 22 Aug 2013 20:03:53 -0400 Received: by mail-pd0-f172.google.com with SMTP id z10so2580584pdj.3 for ; Thu, 22 Aug 2013 17:03:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=K+8ywob04Je45r+7KEI9YpMV0ZD2Zwutgp+w1KnR2nw=; b=cS9zH/7cHbhIil3g8O8AKdDBEz7lSyuR88JYYXBKf+Qzd0LNDRbwqzg0RJH/UGqNSO CWSb3broHiWb5l+d+si+x7VefPOGQ93UO93ytE9e7TWFISaHMGZNmzIk6kPPA7UTaJCF 72n1mgsZMMGs1kPxwaS7dnnvpAHy7OlDdxfG/N9nD3DTIYFXR9VjYvxHB2M9rtZbk9Ag AIGYsSifzuabrVLLeahve7MbgMKWJ4oPTmrd/RC47GpiBBFn/cGEYPkTdEADUKlXb88n GyMKs3R71zPxOY3gpjlhnMaPYxEoJjFxxQZEIsA+9hQuUnpAa9KPyWdrAhngX9eizRk+ mijQ== X-Gm-Message-State: ALoCoQl1HLljW8SAGKAKvHZQy8W8+IdMG2dmu6of3mspySrlkS0qyZknotZACReJcL7rL7YG+E/J X-Received: by 10.66.152.102 with SMTP id ux6mr17578037pab.79.1377216232908; Thu, 22 Aug 2013 17:03:52 -0700 (PDT) Received: from localhost (50-76-60-73-ip-static.hfc.comcastbusiness.net. [50.76.60.73]) by mx.google.com with ESMTPSA id dg3sm17492864pbc.24.1969.12.31.16.00.00 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Thu, 22 Aug 2013 17:03:51 -0700 (PDT) From: Andy Lutomirski To: linux-kernel@vger.kernel.org Cc: linux-ext4@vger.kernel.org, Dave Chinner , Theodore Ts'o , Dave Hansen , xfs@oss.sgi.com, Jan Kara , Tim Chen , Christoph Hellwig , Andy Lutomirski Subject: [PATCH v4 7/7] xfs: Defer mmap cmtime updates Date: Thu, 22 Aug 2013 17:03:23 -0700 Message-Id: <67df6fbc92d9b92a8301b4ad72e2a760d5e662df.1377193658.git.luto@amacapital.net> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: References: In-Reply-To: References: Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org This involves a change to block_page_mkwrite. xfs is the only user. Signed-off-by: Andy Lutomirski --- fs/buffer.c | 7 ------- fs/xfs/xfs_aops.c | 1 + 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/fs/buffer.c b/fs/buffer.c index 4d74335..408677c 100644 --- a/fs/buffer.c +++ b/fs/buffer.c @@ -2431,13 +2431,6 @@ int block_page_mkwrite(struct vm_area_struct *vma, struct vm_fault *vmf, struct super_block *sb = file_inode(vma->vm_file)->i_sb; sb_start_pagefault(sb); - - /* - * Update file times before taking page lock. We may end up failing the - * fault so this update may be superfluous but who really cares... - */ - file_update_time(vma->vm_file); - ret = __block_page_mkwrite(vma, vmf, get_block); sb_end_pagefault(sb); return block_page_mkwrite_return(ret); diff --git a/fs/xfs/xfs_aops.c b/fs/xfs/xfs_aops.c index 596ec71..aa8fbcf 100644 --- a/fs/xfs/xfs_aops.c +++ b/fs/xfs/xfs_aops.c @@ -1668,6 +1668,7 @@ const struct address_space_operations xfs_address_space_operations = { .readpages = xfs_vm_readpages, .writepage = xfs_vm_writepage, .writepages = xfs_vm_writepages, + .update_cmtime_deferred = generic_update_cmtime_deferred, .releasepage = xfs_vm_releasepage, .invalidatepage = xfs_vm_invalidatepage, .write_begin = xfs_vm_write_begin,