From patchwork Mon Feb 21 08:26:32 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marco Stornelli X-Patchwork-Id: 83781 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 0B4E9B7175 for ; Mon, 21 Feb 2011 19:31:34 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752975Ab1BUIbc (ORCPT ); Mon, 21 Feb 2011 03:31:32 -0500 Received: from mail-wy0-f174.google.com ([74.125.82.174]:53789 "EHLO mail-wy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752189Ab1BUIba (ORCPT ); Mon, 21 Feb 2011 03:31:30 -0500 Received: by wyb38 with SMTP id 38so849606wyb.19 for ; Mon, 21 Feb 2011 00:31:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:message-id:date:from:user-agent:mime-version:to :cc:subject:content-type:content-transfer-encoding; bh=jSNmQq33dDOeIbF+1OfmWMXY7U6KcIEZ/+abW39q2m8=; b=qRX+crg1dBfyxQ4QlClSFaxEBE1YblID7+SoJvwg6RcKTPIlBONtL+DzuMTO8555Rm UlZBCQqI026CXQFxJw54x0/cQSaffjpD5fEbgXtHQKEJ578uFirURZtMkx5UZoYYw/nK XyTgsEblzWF6+FeFQBo/zkSG+H2BRi1UUuXQk= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject :content-type:content-transfer-encoding; b=Sel2ZBvT5fwGWvXiokj0R3KdY0ji0vZjaeN62+tIlhgOxcrvMPrxCYeMlZdkTL+GmP wa7cD9bsYr7XiPS4IfSZjo1cpkO7Omj95lteLR30wCX7eBrWicleUQsP0lZZxW04moa8 Y24eV2c6rJ9amZhPmR2g24O1Ztk4ocBfr/UiI= Received: by 10.216.52.143 with SMTP id e15mr1825843wec.44.1298277088957; Mon, 21 Feb 2011 00:31:28 -0800 (PST) Received: from [82.49.176.28] (host28-176-dynamic.49-82-r.retail.telecomitalia.it [82.49.176.28]) by mx.google.com with ESMTPS id t5sm1939037wes.33.2011.02.21.00.31.26 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 21 Feb 2011 00:31:28 -0800 (PST) Message-ID: <4D6221B8.9040303@gmail.com> Date: Mon, 21 Feb 2011 09:26:32 +0100 From: Marco Stornelli User-Agent: Mozilla/5.0 (X11; U; Linux i686; it; rv:1.9.1.16) Gecko/20101125 SUSE/3.0.11 Thunderbird/3.0.11 MIME-Version: 1.0 To: Linux Kernel CC: linux-ext4@vger.kernel.org, linux-btrfs@vger.kernel.org, cluster-devel@redhat.com, xfs@oss.sgi.com, Linux FS Devel Subject: [PATCH] Check for immutable flag in fallocate path Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org From: Marco Stornelli All fs must check for the immutable flag in their fallocate callback. It's possible to have a race condition in this scenario: an application open a file in read/write and it does something, meanwhile root set the immutable flag on the file, the application at that point can call fallocate with success. Only Ocfs2 check for the immutable flag at the moment. Signed-off-by: Marco Stornelli --- Patch is against 2.6.38-rc5 -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- linux-2.6.38-rc5-orig/fs/ext4/extents.c 2011-02-16 04:23:45.000000000 +0100 +++ linux-2.6.38-rc5/fs/ext4/extents.c 2011-02-21 08:43:37.000000000 +0100 @@ -3670,6 +3670,12 @@ long ext4_fallocate(struct file *file, i */ credits = ext4_chunk_trans_blocks(inode, max_blocks); mutex_lock(&inode->i_mutex); + + if (IS_IMMUTABLE(inode)) { + mutex_unlock(&inode->i_mutex); + return -EPERM; + } + ret = inode_newsize_ok(inode, (len + offset)); if (ret) { mutex_unlock(&inode->i_mutex); --- linux-2.6.38-rc5-orig/fs/btrfs/file.c 2011-02-16 04:23:45.000000000 +0100 +++ linux-2.6.38-rc5/fs/btrfs/file.c 2011-02-21 08:55:58.000000000 +0100 @@ -1289,6 +1289,12 @@ static long btrfs_fallocate(struct file btrfs_wait_ordered_range(inode, alloc_start, alloc_end - alloc_start); mutex_lock(&inode->i_mutex); + + if (IS_IMMUTABLE(inode)) { + ret = -EPERM; + goto out; + } + ret = inode_newsize_ok(inode, alloc_end); if (ret) goto out; --- linux-2.6.38-rc5-orig/fs/xfs/linux-2.6/xfs_file.c 2011-02-16 04:23:45.000000000 +0100 +++ linux-2.6.38-rc5/fs/xfs/linux-2.6/xfs_file.c 2011-02-21 09:07:46.000000000 +0100 @@ -909,6 +909,11 @@ xfs_file_fallocate( if (mode & FALLOC_FL_PUNCH_HOLE) cmd = XFS_IOC_UNRESVSP; + if (IS_IMMUTABLE(inode)) { + error = -EPERM; + goto out_unlock; + } + /* check the new inode size is valid before allocating */ if (!(mode & FALLOC_FL_KEEP_SIZE) && offset + len > i_size_read(inode)) { --- linux-2.6.38-rc5-orig/fs/gfs2/file.c 2011-02-16 04:23:45.000000000 +0100 +++ linux-2.6.38-rc5/fs/gfs2/file.c 2011-02-21 09:09:17.000000000 +0100 @@ -797,6 +797,11 @@ static long gfs2_fallocate(struct file * if (unlikely(error)) goto out_uninit; + if (IS_IMMUTABLE(inode)) { + error = -EPERM; + goto out_unlock; + } + if (!gfs2_write_alloc_required(ip, offset, len)) goto out_unlock;