From patchwork Thu Apr 2 17:12:55 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thiemo Nagel X-Patchwork-Id: 25537 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id E0975DDD01 for ; Fri, 3 Apr 2009 04:12:58 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751904AbZDBRM6 (ORCPT ); Thu, 2 Apr 2009 13:12:58 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757468AbZDBRM6 (ORCPT ); Thu, 2 Apr 2009 13:12:58 -0400 Received: from hamlet.e18.physik.tu-muenchen.de ([129.187.154.223]:41243 "EHLO hamlet.e18.physik.tu-muenchen.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755588AbZDBRM5 (ORCPT ); Thu, 2 Apr 2009 13:12:57 -0400 Received: from [129.187.154.161] (earlgrey.e18.physik.tu-muenchen.de [129.187.154.161]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by hamlet.e18.physik.tu-muenchen.de (Postfix) with ESMTP id B82954AFC0; Thu, 2 Apr 2009 19:12:55 +0200 (CEST) Message-ID: <49D4F217.7050105@ph.tum.de> Date: Thu, 02 Apr 2009 19:12:55 +0200 From: Thiemo Nagel User-Agent: Thunderbird 2.0.0.21 (X11/20090302) MIME-Version: 1.0 To: "Aneesh Kumar K.V" , Theodore Tso CC: linux-ext4@vger.kernel.org Subject: [PATCH] off-by-one in "Add checks to validate extent entries." Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org Theodore Tso wrote: > I haven't had time yet to check your other patches; could you also > take a quick scan to make sure we have all of the byte-swapping calls > needed for proper big-endian checking, that we're using the correct > __le32 types and not doing any casts? I had a look at all patches I have sent, but I didn't notice anything suspicious. While doing that, however I think I found an off-by-one in 56b19868aca856a7d7bf20c3a7a1030e4fd75b2b Kind regards, Thiemo --- -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c index ac77d8b..6132353 100644 --- a/fs/ext4/extents.c +++ b/fs/ext4/extents.c @@ -342,7 +342,7 @@ static int ext4_valid_extent_idx(struct inode *inode, ext4_fsblk_t block = idx_pblock(ext_idx); struct ext4_super_block *es = EXT4_SB(inode->i_sb)->s_es; if (unlikely(block < le32_to_cpu(es->s_first_data_block) || - (block > ext4_blocks_count(es)))) + (block >= ext4_blocks_count(es)))) return 0; else return 1;