diff mbox

ext4: simple_strtol returns signed.

Message ID 48FA4558.2020603@gmail.com
State Superseded, archived
Headers show

Commit Message

roel kluin Oct. 18, 2008, 8:21 p.m. UTC
simple_strtol returns signed.

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Theodore Y. Ts'o Oct. 18, 2008, 2:36 p.m. UTC | #1
On Sat, Oct 18, 2008 at 04:21:44PM -0400, roel kluin wrote:
> simple_strtol returns signed.

Actually the better fix is probably to change the use of
simple_strtol() to simple_strtoul().

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index 9b2b2bc..1789dec 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -3516,7 +3516,7 @@  static ssize_t ext4_ui_proc_write(struct file *file, const char __user *buf,
 {
 	unsigned int *p = PDE(file->f_path.dentry->d_inode)->data;
 	char str[32];
-	unsigned long value;
+	long value;
 
 	if (cnt >= sizeof(str))
 		return -EINVAL;