diff mbox

[1/4] jbd2: abort when failed to log metadata buffers

Message ID 48EF1902.5050905@hitachi.com
State Accepted, archived
Headers show

Commit Message

Hidehiro Kawai Oct. 10, 2008, 8:57 a.m. UTC
If we failed to write metadata buffers to the journal space and
succeeded to write the commit record, stale data can be written
back to the filesystem as metadata in the recovery phase.

To avoid this, when we failed to write out metadata buffers,
abort the journal before writing the commit record.

We can also avoid this kind of corruption by using check-summing
feature because it can detect invalid metadata blocks in the
journal and avoid them from being replayed.  So we don't need to
care about asynchronous commit record writeout with a check sum.

Signed-off-by: Hidehiro Kawai <hidehiro.kawai.ez@hitachi.com>
 fs/jbd2/commit.c |    3 +++
 1 file changed, 3 insertions(+)

To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox


Index: linux-2.6.27-rc9-ex4-1/fs/jbd2/commit.c
--- linux-2.6.27-rc9-ex4-1.orig/fs/jbd2/commit.c
+++ linux-2.6.27-rc9-ex4-1/fs/jbd2/commit.c
@@ -783,6 +783,9 @@  wait_for_iobuf:
 		/* AKPM: bforget here */
+	if (err)
+		jbd2_journal_abort(journal, err);
 	jbd_debug(3, "JBD: commit phase 5\n");