diff mbox series

[RFCv1,04/72] badblocks: Remove unused badblocks_flags

Message ID 3b00feafe3b640cc230582eeff4a194a5ba5838b.1667822611.git.ritesh.list@gmail.com
State Under Review
Delegated to: Theodore Ts'o
Headers show
Series e2fsprogs: Parallel fsck support | expand

Commit Message

Ritesh Harjani (IBM) Nov. 7, 2022, 12:20 p.m. UTC
badblocks_flags is not used anywhere. So just remove it.

Signed-off-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
---
 lib/ext2fs/badblocks.c | 6 +-----
 lib/ext2fs/ext2fsP.h   | 1 -
 2 files changed, 1 insertion(+), 6 deletions(-)

Comments

Andreas Dilger Nov. 18, 2022, 1:26 p.m. UTC | #1
On Nov 7, 2022, at 06:22, Ritesh Harjani (IBM) <ritesh.list@gmail.com> wrote:
> 
> ´╗┐badblocks_flags is not used anywhere. So just remove it.
> 
> Signed-off-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>

Reviewed-by: Andreas Dilger <adilger@dilger.ca>

> ---
> lib/ext2fs/badblocks.c | 6 +-----
> lib/ext2fs/ext2fsP.h   | 1 -
> 2 files changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/lib/ext2fs/badblocks.c b/lib/ext2fs/badblocks.c
> index a306bc06..345168e0 100644
> --- a/lib/ext2fs/badblocks.c
> +++ b/lib/ext2fs/badblocks.c
> @@ -81,11 +81,7 @@ errcode_t ext2fs_u32_copy(ext2_u32_list src, ext2_u32_list *dest)
> {
>    errcode_t    retval;
> 
> -    retval = make_u32_list(src->size, src->num, src->list, dest);
> -    if (retval)
> -        return retval;
> -    (*dest)->badblocks_flags = src->badblocks_flags;
> -    return 0;
> +    return make_u32_list(src->size, src->num, src->list, dest);
> }
> 
> errcode_t ext2fs_badblocks_copy(ext2_badblocks_list src,
> diff --git a/lib/ext2fs/ext2fsP.h b/lib/ext2fs/ext2fsP.h
> index a20a0502..d2045af8 100644
> --- a/lib/ext2fs/ext2fsP.h
> +++ b/lib/ext2fs/ext2fsP.h
> @@ -34,7 +34,6 @@ struct ext2_struct_u32_list {
>    int    num;
>    int    size;
>    __u32    *list;
> -    int    badblocks_flags;
> };
> 
> struct ext2_struct_u32_iterate {
> -- 
> 2.37.3
>
diff mbox series

Patch

diff --git a/lib/ext2fs/badblocks.c b/lib/ext2fs/badblocks.c
index a306bc06..345168e0 100644
--- a/lib/ext2fs/badblocks.c
+++ b/lib/ext2fs/badblocks.c
@@ -81,11 +81,7 @@  errcode_t ext2fs_u32_copy(ext2_u32_list src, ext2_u32_list *dest)
 {
 	errcode_t	retval;
 
-	retval = make_u32_list(src->size, src->num, src->list, dest);
-	if (retval)
-		return retval;
-	(*dest)->badblocks_flags = src->badblocks_flags;
-	return 0;
+	return make_u32_list(src->size, src->num, src->list, dest);
 }
 
 errcode_t ext2fs_badblocks_copy(ext2_badblocks_list src,
diff --git a/lib/ext2fs/ext2fsP.h b/lib/ext2fs/ext2fsP.h
index a20a0502..d2045af8 100644
--- a/lib/ext2fs/ext2fsP.h
+++ b/lib/ext2fs/ext2fsP.h
@@ -34,7 +34,6 @@  struct ext2_struct_u32_list {
 	int	num;
 	int	size;
 	__u32	*list;
-	int	badblocks_flags;
 };
 
 struct ext2_struct_u32_iterate {