diff mbox series

ext4, doc: Fix incorrect h_reserved size

Message ID 34889f32-7dd9-125e-2f7a-734faa395d20@huawei.com
State Superseded
Headers show
Series ext4, doc: Fix incorrect h_reserved size | expand

Commit Message

wangjianjian (C) March 31, 2022, 6:37 a.m. UTC
According to document and code, ext4_xattr_header's size is 32 bytes, so
h_reserved size should be 3.

Signed-off-by: Wang Jianjian <wangjianjian3@huawei.com>
---
  Documentation/filesystems/ext4/attributes.rst | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

--
2.32.0

Comments

Jonathan Corbet April 16, 2022, 8:58 a.m. UTC | #1
"wangjianjian (C)" <wangjianjian3@huawei.com> writes:

> According to document and code, ext4_xattr_header's size is 32 bytes, so
> h_reserved size should be 3.
>
> Signed-off-by: Wang Jianjian <wangjianjian3@huawei.com>
> ---
>   Documentation/filesystems/ext4/attributes.rst | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/filesystems/ext4/attributes.rst 
> b/Documentation/filesystems/ext4/attributes.rst
> index 54386a010a8d..871d2da7a0a9 100644
> --- a/Documentation/filesystems/ext4/attributes.rst
> +++ b/Documentation/filesystems/ext4/attributes.rst
> @@ -76,7 +76,7 @@ The beginning of an extended attribute block is in
>        - Checksum of the extended attribute block.
>      * - 0x14
>        - \_\_u32
> -     - h\_reserved[2]
> +     - h\_reserved[3]
>        - Zero.
>

So this patch looks whitespace-damaged, please be sure that you can send
applyable patches to the list.

Beyond that, though, while you're in the neighborhood, please fix the
unnecessary underscore escaping (i.e. s/\_/_/).

Thanks,

jon
wangjianjian (C) April 19, 2022, 8:31 a.m. UTC | #2
>>So this patch looks whitespace-damaged, please be sure that you can send
 >> applyable patches to the list.
Thanks for the notice.

 >> Beyond that, though, while you're in the neighborhood, please fix the
 >> unnecessary underscore escaping (i.e. s/\_/_/).
Sure. Let me fix it.

Thanks,
diff mbox series

Patch

diff --git a/Documentation/filesystems/ext4/attributes.rst 
b/Documentation/filesystems/ext4/attributes.rst
index 54386a010a8d..871d2da7a0a9 100644
--- a/Documentation/filesystems/ext4/attributes.rst
+++ b/Documentation/filesystems/ext4/attributes.rst
@@ -76,7 +76,7 @@  The beginning of an extended attribute block is in
       - Checksum of the extended attribute block.
     * - 0x14
       - \_\_u32
-     - h\_reserved[2]
+     - h\_reserved[3]
       - Zero.

  The checksum is calculated against the FS UUID, the 64-bit block number