From patchwork Fri Feb 26 01:22:58 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zhiqiang Liu X-Patchwork-Id: 1444679 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=linux-ext4-owner@vger.kernel.org; receiver=) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4DmsPd5PyFz9sVS for ; Fri, 26 Feb 2021 12:24:05 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230124AbhBZBXx (ORCPT ); Thu, 25 Feb 2021 20:23:53 -0500 Received: from szxga05-in.huawei.com ([45.249.212.191]:12580 "EHLO szxga05-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230071AbhBZBXt (ORCPT ); Thu, 25 Feb 2021 20:23:49 -0500 Received: from DGGEMS404-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4DmsL65bywzMfD1; Fri, 26 Feb 2021 09:21:02 +0800 (CST) Received: from [127.0.0.1] (10.174.176.117) by DGGEMS404-HUB.china.huawei.com (10.3.19.204) with Microsoft SMTP Server id 14.3.498.0; Fri, 26 Feb 2021 09:22:59 +0800 To: , "Theodore Y. Ts'o" CC: harshad shirwadkar , linfeilong , lihaotian , From: Zhiqiang Liu Subject: [PATCH] misc: remove useless code in set_inode_xattr() Message-ID: <283210da-b281-2dd7-6ef7-b31e81e72e01@huawei.com> Date: Fri, 26 Feb 2021 09:22:58 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 Content-Language: en-US X-Originating-IP: [10.174.176.117] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org In set_inode_xattr(), there are two returns as follows, - return retval; return 0; - Here, we remove useless 'return 0;' code. Signed-off-by: Zhiqiang Liu Reviewed-by: Andreas Dilger --- misc/create_inode.c | 1 - 1 file changed, 1 deletion(-) diff --git a/misc/create_inode.c b/misc/create_inode.c index 54d8d343..d62e1cb4 100644 --- a/misc/create_inode.c +++ b/misc/create_inode.c @@ -234,7 +234,6 @@ static errcode_t set_inode_xattr(ext2_filsys fs, ext2_ino_t ino, retval = retval ? retval : close_retval; } return retval; - return 0; } #else /* HAVE_LLISTXATTR */ static errcode_t set_inode_xattr(ext2_filsys fs EXT2FS_ATTR((unused)),