| Message ID | 20240227091148.178435-10-libaokun1@huawei.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | ext4: avoid sysfs variables overflow causing BUG_ON/SOOB | expand |
On Tue 27-02-24 17:11:48, Baokun Li wrote: > Running sparse (make C=1) on mballoc.c we get the following warning: > > fs/ext4/mballoc.c:3194:13: warning: context imbalance in > 'ext4_mb_seq_structs_summary_start' - wrong count at exit > > This is because __acquires(&EXT4_SB(sb)->s_mb_rb_lock) was called in > ext4_mb_seq_structs_summary_start(), but s_mb_rb_lock was removed in commit > 83e80a6e3543 ("ext4: use buckets for cr 1 block scan instead of rbtree"), > so remove the __acquires to silence the warning. > > Signed-off-by: Baokun Li <libaokun1@huawei.com> Looks good. Feel free to add: Reviewed-by: Jan Kara <jack@suse.cz> Honza > --- > fs/ext4/mballoc.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c > index 7ad089df2408..7ae8e04d6ef4 100644 > --- a/fs/ext4/mballoc.c > +++ b/fs/ext4/mballoc.c > @@ -3192,7 +3192,6 @@ int ext4_seq_mb_stats_show(struct seq_file *seq, void *offset) > } > > static void *ext4_mb_seq_structs_summary_start(struct seq_file *seq, loff_t *pos) > -__acquires(&EXT4_SB(sb)->s_mb_rb_lock) > { > struct super_block *sb = pde_data(file_inode(seq->file)); > unsigned long position; > -- > 2.31.1 >
diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c index 7ad089df2408..7ae8e04d6ef4 100644 --- a/fs/ext4/mballoc.c +++ b/fs/ext4/mballoc.c @@ -3192,7 +3192,6 @@ int ext4_seq_mb_stats_show(struct seq_file *seq, void *offset) } static void *ext4_mb_seq_structs_summary_start(struct seq_file *seq, loff_t *pos) -__acquires(&EXT4_SB(sb)->s_mb_rb_lock) { struct super_block *sb = pde_data(file_inode(seq->file)); unsigned long position;
Running sparse (make C=1) on mballoc.c we get the following warning: fs/ext4/mballoc.c:3194:13: warning: context imbalance in 'ext4_mb_seq_structs_summary_start' - wrong count at exit This is because __acquires(&EXT4_SB(sb)->s_mb_rb_lock) was called in ext4_mb_seq_structs_summary_start(), but s_mb_rb_lock was removed in commit 83e80a6e3543 ("ext4: use buckets for cr 1 block scan instead of rbtree"), so remove the __acquires to silence the warning. Signed-off-by: Baokun Li <libaokun1@huawei.com> --- fs/ext4/mballoc.c | 1 - 1 file changed, 1 deletion(-)