| Message ID | 20240102112012.672260-1-yangerkun@huawei.com |
|---|---|
| State | New |
| Headers | show |
| Series | ext4: return 0 when ext4_get_group_info failed in __mb_check_buddy | expand |
on 1/2/2024 7:20 PM, yangerkun wrote: > The return value for __mb_check_buddy should be a integer. Found this by > code review. > Hi yangerkun, I think the return value of __mb_check_buddy is actually not used and can be removed. See [1] for details :). Thanks! [1] https://lore.kernel.org/lkml/20231125161143.3945726-2-shikemeng@huaweicloud.com/ > Fixes: 5354b2af3406 ("ext4: allow ext4_get_group_info() to fail") > Signed-off-by: yangerkun <yangerkun@huawei.com> > --- > fs/ext4/mballoc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c > index d72b5e3c92ec..55c70a1b445a 100644 > --- a/fs/ext4/mballoc.c > +++ b/fs/ext4/mballoc.c > @@ -758,7 +758,7 @@ static int __mb_check_buddy(struct ext4_buddy *e4b, char *file, > > grp = ext4_get_group_info(sb, e4b->bd_group); > if (!grp) > - return NULL; > + return 0; > list_for_each(cur, &grp->bb_prealloc_list) { > ext4_group_t groupnr; > struct ext4_prealloc_space *pa; >
在 2024/1/2 20:17, Kemeng Shi 写道: > > > on 1/2/2024 7:20 PM, yangerkun wrote: >> The return value for __mb_check_buddy should be a integer. Found this by >> code review. >> > Hi yangerkun, > I think the return value of __mb_check_buddy is actually not used and can > be removed. See [1] for details :). Thanks! Hi Kemeng, Yeah, the return value nowdays help nothing, it's a good choice to remove them all. Thanks. > > [1] https://lore.kernel.org/lkml/20231125161143.3945726-2-shikemeng@huaweicloud.com/ > >> Fixes: 5354b2af3406 ("ext4: allow ext4_get_group_info() to fail") >> Signed-off-by: yangerkun <yangerkun@huawei.com> >> --- >> fs/ext4/mballoc.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c >> index d72b5e3c92ec..55c70a1b445a 100644 >> --- a/fs/ext4/mballoc.c >> +++ b/fs/ext4/mballoc.c >> @@ -758,7 +758,7 @@ static int __mb_check_buddy(struct ext4_buddy *e4b, char *file, >> >> grp = ext4_get_group_info(sb, e4b->bd_group); >> if (!grp) >> - return NULL; >> + return 0; >> list_for_each(cur, &grp->bb_prealloc_list) { >> ext4_group_t groupnr; >> struct ext4_prealloc_space *pa; >> >
diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c index d72b5e3c92ec..55c70a1b445a 100644 --- a/fs/ext4/mballoc.c +++ b/fs/ext4/mballoc.c @@ -758,7 +758,7 @@ static int __mb_check_buddy(struct ext4_buddy *e4b, char *file, grp = ext4_get_group_info(sb, e4b->bd_group); if (!grp) - return NULL; + return 0; list_for_each(cur, &grp->bb_prealloc_list) { ext4_group_t groupnr; struct ext4_prealloc_space *pa;
The return value for __mb_check_buddy should be a integer. Found this by code review. Fixes: 5354b2af3406 ("ext4: allow ext4_get_group_info() to fail") Signed-off-by: yangerkun <yangerkun@huawei.com> --- fs/ext4/mballoc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)