diff mbox series

[V2] ext4: delete redundant calculations in ext4_mb_get_buddy_page_lock()

Message ID 20231024035215.29474-1-gouhao@uniontech.com
State New
Headers show
Series [V2] ext4: delete redundant calculations in ext4_mb_get_buddy_page_lock() | expand

Commit Message

Gou Hao Oct. 24, 2023, 3:52 a.m. UTC 
'blocks_per_page' is always 1 after 'if (blocks_per_page >= 2)',
'pnum' and 'block' are equal in this case.

Signed-off-by: Gou Hao <gouhao@uniontech.com>
Reviewed-by: Jan Kara <jack@suse.cz>
---
 fs/ext4/mballoc.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

Comments

Theodore Ts'o Jan. 9, 2024, 2:53 a.m. UTC | #1 
On Tue, 24 Oct 2023 11:52:15 +0800, Gou Hao wrote:
> 'blocks_per_page' is always 1 after 'if (blocks_per_page >= 2)',
> 'pnum' and 'block' are equal in this case.
> 
> 

Applied, thanks!

[1/1] ext4: delete redundant calculations in ext4_mb_get_buddy_page_lock()
      commit: f2fec3e99a32d7c14dbf63c824f8286ebc94b18d

Best regards,
diff mbox series

Patch

diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
index 454d5612641e..c340d4d7287a 100644
--- a/fs/ext4/mballoc.c
+++ b/fs/ext4/mballoc.c
@@ -1456,9 +1456,8 @@  static int ext4_mb_get_buddy_page_lock(struct super_block *sb,
 		return 0;
 	}
 
-	block++;
-	pnum = block / blocks_per_page;
-	page = find_or_create_page(inode->i_mapping, pnum, gfp);
+	/* blocks_per_page == 1, hence we need another page for the buddy */
+	page = find_or_create_page(inode->i_mapping, block + 1, gfp);
 	if (!page)
 		return -ENOMEM;
 	BUG_ON(page->mapping != inode->i_mapping);