diff mbox series

[v3,03/13] ext4: correct return value of ext4_convert_meta_bg

Message ID 20230826174712.4059355-4-shikemeng@huaweicloud.com
State Accepted
Headers show
Series fixes and cleanups to ext4 resize | expand

Commit Message

Kemeng Shi Aug. 26, 2023, 5:47 p.m. UTC 
Avoid to ignore error in "err".

Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>
---
 fs/ext4/resize.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
diff mbox series

Patch

diff --git a/fs/ext4/resize.c b/fs/ext4/resize.c
index 7cbc695b7005..9cb9ed968599 100644
--- a/fs/ext4/resize.c
+++ b/fs/ext4/resize.c
@@ -1984,9 +1984,7 @@  static int ext4_convert_meta_bg(struct super_block *sb, struct inode *inode)
 
 errout:
 	ret = ext4_journal_stop(handle);
-	if (!err)
-		err = ret;
-	return ret;
+	return err ? err : ret;
 
 invalid_resize_inode:
 	ext4_error(sb, "corrupted/inconsistent resize inode");