[v2,09/13] ext4: remove EXT4FS_DEBUG defination in resize.c

Message ID	20230826173735.4023594-10-shikemeng@huaweicloud.com
State	Superseded
Headers	show Return-Path: <SRS0=sxB8=EL=vger.kernel.org=linux-ext4-owner@ozlabs.org> From: Kemeng Shi <shikemeng@huaweicloud.com> To: tytso@mit.edu, adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 09/13] ext4: remove EXT4FS_DEBUG defination in resize.c Date: Sun, 27 Aug 2023 01:37:31 +0800 Message-Id: <20230826173735.4023594-10-shikemeng@huaweicloud.com> In-Reply-To: <20230826173735.4023594-1-shikemeng@huaweicloud.com> References: <20230826173735.4023594-1-shikemeng@huaweicloud.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk
Series	fixes and cleanups to ext4 resize \| expand [v2,00/13] fixes and cleanups to ext4 resize [v2,01/13] ext4: correct offset of gdb backup in non meta_bg group to update_backups [v2,02/13] ext4: add missed brelse in update_backups [v2,03/13] ext4: correct return value of ext4_convert_meta_bg [v2,04/13] ext4: remove gdb backup copy for meta bg in setup_new_flex_group_blocks [v2,05/13] ext4: fix typo in setup_new_flex_group_blocks [v2,06/13] ext4: remove redundant check of count [v2,07/13] ext4: remove commented code in reserve_backup_gdb [v2,08/13] ext4: calculate free_clusters_count in cluster unit in verify_group_input [v2,09/13] ext4: remove EXT4FS_DEBUG defination in resize.c [v2,10/13] ext4: use saved local variable sbi instead of EXT4_SB(sb) [v2,11/13] ext4: simplify the gdbblock calculation in add_new_gdb_meta_bg [v2,12/13] ext4: remove unnecessary check to avoid repeat update_backups for the same gdb [v2,13/13] ext4: remove unnecessary initialization of count2 in set_flexbg_block_bitmap

Message ID

20230826173735.4023594-10-shikemeng@huaweicloud.com

State

Superseded

Headers

From: Kemeng Shi <shikemeng@huaweicloud.com>
To: tytso@mit.edu, adilger.kernel@dilger.ca,
        linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2 09/13] ext4: remove EXT4FS_DEBUG defination in resize.c
Date: Sun, 27 Aug 2023 01:37:31 +0800
Message-Id: <20230826173735.4023594-10-shikemeng@huaweicloud.com>
In-Reply-To: <20230826173735.4023594-1-shikemeng@huaweicloud.com>
References: <20230826173735.4023594-1-shikemeng@huaweicloud.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

Series

fixes and cleanups to ext4 resize | expand

Commit Message

Kemeng Shi Aug. 26, 2023, 5:37 p.m. UTC

Remove EXT4FS_DEBUG defination in resize.c for following reasons:
1. EXT4FS_DEBUG will enable debug messages, it should only be defined
when debugging.
2. ext4.h included from ext4_jbd2.h after EXT4FS_DEBUG defination will
"#undef EXT4FS_DEBUG", then EXT4FS_DEBUG defination in resize.c can't
actually turn on ext4_debug messages.

Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>
Reviewed-by: Theodore Ts'o <tytso@mit.edu>
---
 fs/ext4/resize.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/fs/ext4/resize.c b/fs/ext4/resize.c
index 3ad2b1a900ad..d4ab2cde0a03 100644
--- a/fs/ext4/resize.c
+++ b/fs/ext4/resize.c
@@ -10,8 +10,6 @@ 
  */
 
 
-#define EXT4FS_DEBUG
-
 #include <linux/errno.h>
 #include <linux/slab.h>
 #include <linux/jiffies.h>

[v2,09/13] ext4: remove EXT4FS_DEBUG defination in resize.c

Commit Message

Patch