| Message ID | 20230826085658.69769-1-hchunhui@mail.ustc.edu.cn |
|---|---|
| State | New |
| Headers | show |
| Series | None | expand |
On Sat 26-08-23 08:56:58, Chunhui He wrote: > The gcc document says label attributes are ambiguous if they are > not immediately followed by a semicolon. Although the ambiguity > does not arise in C90/99, it would be better to add it. > > Link: https://gcc.gnu.org/onlinedocs/gcc/Attribute-Syntax.html#Label-Attributes-2 > Signed-off-by: Chunhui He <hchunhui@mail.ustc.edu.cn> Fair enough. Feel free to add: Reviewed-by: Jan Kara <jack@suse.cz> Honza > --- > fs/ext4/super.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/ext4/super.c b/fs/ext4/super.c > index c94ebf704616..f5fa9815a86e 100644 > --- a/fs/ext4/super.c > +++ b/fs/ext4/super.c > @@ -5609,7 +5609,7 @@ static int __ext4_fill_super(struct fs_context *fc, struct super_block *sb) > > failed_mount10: > ext4_quotas_off(sb, EXT4_MAXQUOTAS); > -failed_mount9: __maybe_unused > +failed_mount9: __maybe_unused; > ext4_release_orphan_info(sb); > failed_mount8: > ext4_unregister_sysfs(sb); > -- > 2.39.2 > >
diff --git a/fs/ext4/super.c b/fs/ext4/super.c index c94ebf704616..f5fa9815a86e 100644 --- a/fs/ext4/super.c +++ b/fs/ext4/super.c @@ -5609,7 +5609,7 @@ static int __ext4_fill_super(struct fs_context *fc, struct super_block *sb) failed_mount10: ext4_quotas_off(sb, EXT4_MAXQUOTAS); -failed_mount9: __maybe_unused +failed_mount9: __maybe_unused; ext4_release_orphan_info(sb); failed_mount8: ext4_unregister_sysfs(sb);
The gcc document says label attributes are ambiguous if they are not immediately followed by a semicolon. Although the ambiguity does not arise in C90/99, it would be better to add it. Link: https://gcc.gnu.org/onlinedocs/gcc/Attribute-Syntax.html#Label-Attributes-2 Signed-off-by: Chunhui He <hchunhui@mail.ustc.edu.cn> --- fs/ext4/super.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)