| Message ID | 20220814090016.3160-1-sunjunchao2870@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Documentation: ext4: correct the document about superblock | expand |
On Sun, Aug 14, 2022 at 02:00:16AM -0700, JunChao Sun wrote: > Correct some questions like this: > s_lastcheck_hi field should be upper 8 bits of the > s_lastcheck field, rather than itself. > > diff --git a/Documentation/filesystems/ext4/super.rst b/Documentation/filesystems/ext4/super.rst > index 268888522e35..0152888cac29 100644 > --- a/Documentation/filesystems/ext4/super.rst > +++ b/Documentation/filesystems/ext4/super.rst > @@ -456,15 +456,15 @@ The ext4 superblock is laid out as follows in > * - 0x277 > - __u8 > - s_lastcheck_hi > - - Upper 8 bits of the s_lastcheck_hi field. > + - Upper 8 bits of the s_lastcheck field. > * - 0x278 > - __u8 > - s_first_error_time_hi > - - Upper 8 bits of the s_first_error_time_hi field. > + - Upper 8 bits of the s_first_error_time field. > * - 0x279 > - __u8 > - s_last_error_time_hi > - - Upper 8 bits of the s_last_error_time_hi field. > + - Upper 8 bits of the s_last_error_time field. > * - 0x27A > - __u8 > - s_pad[2] The diff looks OK, but the description should be: "The description of s_lastcheck_hi, s_first_error_time_hi, and s_last_error_time_hi fields refer to themselves, while these means referring to upper 8 bits (byte) of corresponding fields (s_lastcheck, s_first_error_time, and s_last_error_time). Correct the mistake." Thanks.
Thanks for your suggestions, I will send patchv2. On Mon, Aug 15, 2022 at 5:21 PM Bagas Sanjaya <bagasdotme@gmail.com> wrote: > > On Sun, Aug 14, 2022 at 02:00:16AM -0700, JunChao Sun wrote: > > Correct some questions like this: > > s_lastcheck_hi field should be upper 8 bits of the > > s_lastcheck field, rather than itself. > > > > diff --git a/Documentation/filesystems/ext4/super.rst b/Documentation/filesystems/ext4/super.rst > > index 268888522e35..0152888cac29 100644 > > --- a/Documentation/filesystems/ext4/super.rst > > +++ b/Documentation/filesystems/ext4/super.rst > > @@ -456,15 +456,15 @@ The ext4 superblock is laid out as follows in > > * - 0x277 > > - __u8 > > - s_lastcheck_hi > > - - Upper 8 bits of the s_lastcheck_hi field. > > + - Upper 8 bits of the s_lastcheck field. > > * - 0x278 > > - __u8 > > - s_first_error_time_hi > > - - Upper 8 bits of the s_first_error_time_hi field. > > + - Upper 8 bits of the s_first_error_time field. > > * - 0x279 > > - __u8 > > - s_last_error_time_hi > > - - Upper 8 bits of the s_last_error_time_hi field. > > + - Upper 8 bits of the s_last_error_time field. > > * - 0x27A > > - __u8 > > - s_pad[2] > > The diff looks OK, but the description should be: > "The description of s_lastcheck_hi, s_first_error_time_hi, and > s_last_error_time_hi fields refer to themselves, while these means > referring to upper 8 bits (byte) of corresponding fields (s_lastcheck, > s_first_error_time, and s_last_error_time). Correct the mistake." > > Thanks. > > -- > An old man doll... just what I always wanted! - Clara
diff --git a/Documentation/filesystems/ext4/super.rst b/Documentation/filesystems/ext4/super.rst index 268888522e35..0152888cac29 100644 --- a/Documentation/filesystems/ext4/super.rst +++ b/Documentation/filesystems/ext4/super.rst @@ -456,15 +456,15 @@ The ext4 superblock is laid out as follows in * - 0x277 - __u8 - s_lastcheck_hi - - Upper 8 bits of the s_lastcheck_hi field. + - Upper 8 bits of the s_lastcheck field. * - 0x278 - __u8 - s_first_error_time_hi - - Upper 8 bits of the s_first_error_time_hi field. + - Upper 8 bits of the s_first_error_time field. * - 0x279 - __u8 - s_last_error_time_hi - - Upper 8 bits of the s_last_error_time_hi field. + - Upper 8 bits of the s_last_error_time field. * - 0x27A - __u8 - s_pad[2]
Correct some questions like this: s_lastcheck_hi field should be upper 8 bits of the s_lastcheck field, rather than itself. Signed-off-by: JunChao Sun <sunjunchao2870@gmail.com> --- Documentation/filesystems/ext4/super.rst | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)