| Message ID | 20211214205617.17233-1-enwlinux@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | xfstests-bld: add ext4/044 to adv.exclude | expand |
On Tue, Dec 14, 2021 at 03:56:17PM -0500, Eric Whitney wrote: > Test ext4/044 fails when run in the adv test case because it explicitly > attempts to mount a test file system created with the inline_data > feature as ext3. The inline_data feature and ext3 are incompatible, > and the mount attempt fails. > > This test did not fail in earlier xfstests-bld versions because the > features included in adv were different. In particular, the 64bit > feature was applied, and this had an unfortunate side effect. > Because the 64bit feature requires extents, and because the test > attempts to create an ext3 file system, the initial attempt actually > failed. This was hidden by behavior in the xfstest function > _scratch_do_mkfs, which then attempted to create the file system without > the supplied "extra" mkfs options (those supplied for the adv test case). > So, the test file system was not created with inline_data, the explicit > attempt to mount the test file system as ext3 succeeded, and the test > passed without testing anything particular to the adv test case. > > Signed-off-by: Eric Whitney <enwlinux@gmail.com> Thanks, applied. - Ted
diff --git a/kvm-xfstests/test-appliance/files/root/fs/ext4/cfg/adv.exclude b/kvm-xfstests/test-appliance/files/root/fs/ext4/cfg/adv.exclude index b6c802d..42d7451 100644 --- a/kvm-xfstests/test-appliance/files/root/fs/ext4/cfg/adv.exclude +++ b/kvm-xfstests/test-appliance/files/root/fs/ext4/cfg/adv.exclude @@ -1,5 +1,9 @@ ext4/004 # dump/restore doesn't handle inline data +# ext4/044 tries to mount the file system as ext3 explicitly. This will +# fail because ext3 and the inline_data feature are incompatible. +ext4/044 + # This takes a *long* time and doesn't add much value to run on all # configurations. So we're going to be selective where we run it. generic/027
Test ext4/044 fails when run in the adv test case because it explicitly attempts to mount a test file system created with the inline_data feature as ext3. The inline_data feature and ext3 are incompatible, and the mount attempt fails. This test did not fail in earlier xfstests-bld versions because the features included in adv were different. In particular, the 64bit feature was applied, and this had an unfortunate side effect. Because the 64bit feature requires extents, and because the test attempts to create an ext3 file system, the initial attempt actually failed. This was hidden by behavior in the xfstest function _scratch_do_mkfs, which then attempted to create the file system without the supplied "extra" mkfs options (those supplied for the adv test case). So, the test file system was not created with inline_data, the explicit attempt to mount the test file system as ext3 succeeded, and the test passed without testing anything particular to the adv test case. Signed-off-by: Eric Whitney <enwlinux@gmail.com> --- .../test-appliance/files/root/fs/ext4/cfg/adv.exclude | 4 ++++ 1 file changed, 4 insertions(+)