diff mbox series

[v2] ext4: Remove redundant statement

Message ID 20211104063406.2747-1-luo.penghao@zte.com
State Awaiting Upstream
Headers show
Series [v2] ext4: Remove redundant statement | expand

Commit Message

CGEL Nov. 4, 2021, 6:34 a.m. UTC 
From: luo penghao <luo.penghao@zte.com.cn>

The local variable assignment at the end of the function is meaningless.

The clang_analyzer complains as follows:

fs/ext4/fast_commit.c:779:2 warning:

Value stored to 'dst' is never read

change in v2:

Repair the sending email box

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: luo penghao <luo.penghao@zte.com.cn>
---
 fs/ext4/fast_commit.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Theodore Ts'o Jan. 5, 2022, 11:39 p.m. UTC | #1 
On Thu, 4 Nov 2021 06:34:06 +0000, cgel.zte@gmail.com wrote:
> From: luo penghao <luo.penghao@zte.com.cn>
> 
> The local variable assignment at the end of the function is meaningless.
> 
> The clang_analyzer complains as follows:
> 
> fs/ext4/fast_commit.c:779:2 warning:
> 
> [...]

Applied, thanks!

[1/1] ext4: remove redundant statement
      commit: 756e311f7f200754096117caf9ef9d656edb280f

Best regards,
diff mbox series

Patch

diff --git a/fs/ext4/fast_commit.c b/fs/ext4/fast_commit.c
index 782d05a..9e5bfa0 100644
--- a/fs/ext4/fast_commit.c
+++ b/fs/ext4/fast_commit.c
@@ -797,7 +797,6 @@  static  bool ext4_fc_add_dentry_tlv(struct super_block *sb, u16 tag,
 	ext4_fc_memcpy(sb, dst, &fcd, sizeof(fcd), crc);
 	dst += sizeof(fcd);
 	ext4_fc_memcpy(sb, dst, dname, dlen, crc);
-	dst += dlen;
 
 	return true;
 }