diff mbox series

e2fsck: Make sure quota files are not referenced from dirs

Message ID 20210812133216.26539-1-jack@suse.cz
State Accepted
Headers show
Series e2fsck: Make sure quota files are not referenced from dirs | expand

Commit Message

Jan Kara Aug. 12, 2021, 1:32 p.m. UTC
Quota files must not be referenced from directory entries. Otherwise
they can get corrupted under the hands of the kernel.

Signed-off-by: Jan Kara <jack@suse.cz>
---
 e2fsck/pass2.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

Comments

Theodore Ts'o Aug. 13, 2021, 4:52 p.m. UTC | #1
On Thu, 12 Aug 2021 15:32:16 +0200, Jan Kara wrote:
> Quota files must not be referenced from directory entries. Otherwise
> they can get corrupted under the hands of the kernel.
> 
> 
> 
> 

Applied, thanks!

[1/1] e2fsck: Make sure quota files are not referenced from dirs
      (no commit info)

Best regards,
diff mbox series

Patch

diff --git a/e2fsck/pass2.c b/e2fsck/pass2.c
index bd974c551b74..cb80d33311bc 100644
--- a/e2fsck/pass2.c
+++ b/e2fsck/pass2.c
@@ -1441,7 +1441,10 @@  skip_checksum:
 		name_len = ext2fs_dirent_name_len(dirent);
 		if (((dirent->inode != EXT2_ROOT_INO) &&
 		     (dirent->inode < EXT2_FIRST_INODE(fs->super))) ||
-		    (dirent->inode > fs->super->s_inodes_count)) {
+		    (dirent->inode > fs->super->s_inodes_count) ||
+		    (dirent->inode == fs->super->s_usr_quota_inum) ||
+		    (dirent->inode == fs->super->s_grp_quota_inum) ||
+		    (dirent->inode == fs->super->s_prj_quota_inum)) {
 			problem = PR_2_BAD_INO;
 		} else if (ctx->inode_bb_map &&
 			   (ext2fs_test_inode_bitmap2(ctx->inode_bb_map,