diff mbox series

ext4: no need to verify new add extent block

Message ID 20210609075545.1442160-1-yangerkun@huawei.com
State Awaiting Upstream
Headers show
Series ext4: no need to verify new add extent block | expand

Commit Message

yangerkun June 9, 2021, 7:55 a.m. UTC
ext4_ext_grow_indepth will add a new extent block which has init the
expected content. We can mark this buffer as verified so to stop a
useless check in __read_extent_tree_block.

Signed-off-by: yangerkun <yangerkun@huawei.com>
---
 fs/ext4/extents.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Jan Kara June 9, 2021, 9:57 a.m. UTC | #1
On Wed 09-06-21 15:55:45, yangerkun wrote:
> ext4_ext_grow_indepth will add a new extent block which has init the
> expected content. We can mark this buffer as verified so to stop a
> useless check in __read_extent_tree_block.
> 
> Signed-off-by: yangerkun <yangerkun@huawei.com>

Looks good. Feel free to add:

Reviewed-by: Jan Kara <jack@suse.cz>

								Honza

> ---
>  fs/ext4/extents.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
> index cbf37b2cf871..6ca5be8a8fc2 100644
> --- a/fs/ext4/extents.c
> +++ b/fs/ext4/extents.c
> @@ -1306,6 +1306,7 @@ static int ext4_ext_grow_indepth(handle_t *handle, struct inode *inode,
>  	neh->eh_magic = EXT4_EXT_MAGIC;
>  	ext4_extent_block_csum_set(inode, neh);
>  	set_buffer_uptodate(bh);
> +	set_buffer_verified(bh);
>  	unlock_buffer(bh);
>  
>  	err = ext4_handle_dirty_metadata(handle, inode, bh);
> -- 
> 2.31.1
>
Theodore Ts'o June 24, 2021, 2:29 p.m. UTC | #2
On Wed, Jun 09, 2021 at 03:55:45PM +0800, yangerkun wrote:
> ext4_ext_grow_indepth will add a new extent block which has init the
> expected content. We can mark this buffer as verified so to stop a
> useless check in __read_extent_tree_block.
> 
> Signed-off-by: yangerkun <yangerkun@huawei.com>

Applied, thanks.

						- Ted
diff mbox series

Patch

diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index cbf37b2cf871..6ca5be8a8fc2 100644
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
@@ -1306,6 +1306,7 @@  static int ext4_ext_grow_indepth(handle_t *handle, struct inode *inode,
 	neh->eh_magic = EXT4_EXT_MAGIC;
 	ext4_extent_block_csum_set(inode, neh);
 	set_buffer_uptodate(bh);
+	set_buffer_verified(bh);
 	unlock_buffer(bh);
 
 	err = ext4_handle_dirty_metadata(handle, inode, bh);