diff mbox series

use local variables ei instead of invoking function EXT4_I

Message ID 20210526052930.11278-1-chenyichong@uniontech.com
State Awaiting Upstream
Headers show
Series use local variables ei instead of invoking function EXT4_I | expand

Commit Message

chenyichong May 26, 2021, 5:29 a.m. UTC
Signed-off-by: chenyichong <chenyichong@uniontech.com>
---
 fs/ext4/inode.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Ritesh Harjani May 27, 2021, 2:49 a.m. UTC | #1
On 21/05/26 01:29PM, chenyichong wrote:

Thanks for the patch. Looks good to me.
Feel free to add

Reviewed-by: Ritesh Harjani <riteshh@linux.ibm.com>


> Signed-off-by: chenyichong <chenyichong@uniontech.com>
> ---
>  fs/ext4/inode.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
> index fe6045a46599..a5c4cd1c757b 100644
> --- a/fs/ext4/inode.c
> +++ b/fs/ext4/inode.c
> @@ -374,7 +374,7 @@ void ext4_da_update_reserve_space(struct inode *inode,
>  	ei->i_reserved_data_blocks -= used;
>  	percpu_counter_sub(&sbi->s_dirtyclusters_counter, used);
>
> -	spin_unlock(&EXT4_I(inode)->i_block_reservation_lock);
> +	spin_unlock(&ei->i_block_reservation_lock);
>
>  	/* Update quota subsystem for data blocks */
>  	if (quota_claim)
> --
> 2.20.1
>
>
>
Theodore Ts'o June 17, 2021, 8:23 p.m. UTC | #2
On Wed, May 26, 2021 at 01:29:30PM +0800, chenyichong wrote:
> Signed-off-by: chenyichong <chenyichong@uniontech.com>

Applied, thanks.

					- Ted
diff mbox series

Patch

diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
index fe6045a46599..a5c4cd1c757b 100644
--- a/fs/ext4/inode.c
+++ b/fs/ext4/inode.c
@@ -374,7 +374,7 @@  void ext4_da_update_reserve_space(struct inode *inode,
 	ei->i_reserved_data_blocks -= used;
 	percpu_counter_sub(&sbi->s_dirtyclusters_counter, used);
 
-	spin_unlock(&EXT4_I(inode)->i_block_reservation_lock);
+	spin_unlock(&ei->i_block_reservation_lock);
 
 	/* Update quota subsystem for data blocks */
 	if (quota_claim)