diff mbox series

ext4: fix double locking in ext4_fc_commit_dentry_updates()

Message ID 20201023161339.1449437-1-harshadshirwadkar@gmail.com
State Awaiting Upstream
Headers show
Series ext4: fix double locking in ext4_fc_commit_dentry_updates() | expand

Commit Message

harshad shirwadkar Oct. 23, 2020, 4:13 p.m. UTC
Fixed double locking of sbi->s_fc_lock in the above function
as reported by kernel-test-robot.

Signed-off-by: Harshad Shirwadkar <harshadshirwadkar@gmail.com>
---
 fs/ext4/fast_commit.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Theodore Y. Ts'o Oct. 28, 2020, 3:52 a.m. UTC | #1
On Fri, Oct 23, 2020 at 09:13:39AM -0700, Harshad Shirwadkar wrote:
> Fixed double locking of sbi->s_fc_lock in the above function
> as reported by kernel-test-robot.
> 
> Signed-off-by: Harshad Shirwadkar <harshadshirwadkar@gmail.com>

Thanks, applied.

					- Ted
diff mbox series

Patch

diff --git a/fs/ext4/fast_commit.c b/fs/ext4/fast_commit.c
index 447c8d93f480..1d72f8f13a05 100644
--- a/fs/ext4/fast_commit.c
+++ b/fs/ext4/fast_commit.c
@@ -964,7 +964,6 @@  static int ext4_fc_commit_dentry_updates(journal_t *journal, u32 *crc)
 			fc_dentry->fcd_parent, fc_dentry->fcd_ino,
 			fc_dentry->fcd_name.len,
 			fc_dentry->fcd_name.name, crc)) {
-			spin_lock(&sbi->s_fc_lock);
 			ret = -ENOSPC;
 			goto lock_and_exit;
 		}