| Message ID | 20200810022158.9167-1-vulab@iscas.ac.cn |
|---|---|
| State | Awaiting Upstream |
| Headers | show |
| Series | mballoc: Replace seq_printf with seq_puts | expand |
On 8/10/20 7:51 AM, Xu Wang wrote: > seq_puts is a lot cheaper than seq_printf, so use that to print > literal strings. > > Signed-off-by: Xu Wang <vulab@iscas.ac.cn> Looks good to me. Reviewed-by: Ritesh Harjani <riteshh@linux.ibm.com>
On Mon, Aug 10, 2020 at 02:21:58AM +0000, Xu Wang wrote: > seq_puts is a lot cheaper than seq_printf, so use that to print > literal strings. > > Signed-off-by: Xu Wang <vulab@iscas.ac.cn> Applied, thanks. - Ted
diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c index c0a331e2feb0..77288e549a95 100644 --- a/fs/ext4/mballoc.c +++ b/fs/ext4/mballoc.c @@ -2439,7 +2439,7 @@ static int ext4_mb_seq_groups_show(struct seq_file *seq, void *v) for (i = 0; i <= 13; i++) seq_printf(seq, " %-5u", i <= blocksize_bits + 1 ? sg.info.bb_counters[i] : 0); - seq_printf(seq, " ]\n"); + seq_puts(seq, " ]\n"); return 0; }
seq_puts is a lot cheaper than seq_printf, so use that to print literal strings. Signed-off-by: Xu Wang <vulab@iscas.ac.cn> --- fs/ext4/mballoc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)