diff mbox series

ext2: delete incorrect comment for ext2_blks_to_allocate()

Message ID 20200702095636.29246-1-cgxu519@mykernel.net
State New
Headers show
Series ext2: delete incorrect comment for ext2_blks_to_allocate() | expand

Commit Message

Chengguang Xu July 2, 2020, 9:56 a.m. UTC
ext2_blks_to_allocate() only counts direct blocks need to be allocated,
return value does not include indirect blocks.

Signed-off-by: Chengguang Xu <cgxu519@mykernel.net>
---
 fs/ext2/inode.c | 3 ---
 1 file changed, 3 deletions(-)

Comments

Jan Kara July 3, 2020, 10:20 a.m. UTC | #1
On Thu 02-07-20 17:56:36, Chengguang Xu wrote:
> ext2_blks_to_allocate() only counts direct blocks need to be allocated,
> return value does not include indirect blocks.
> 
> Signed-off-by: Chengguang Xu <cgxu519@mykernel.net>
> ---
>  fs/ext2/inode.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/fs/ext2/inode.c b/fs/ext2/inode.c
> index c8b371c82b4f..4df849e694dd 100644
> --- a/fs/ext2/inode.c
> +++ b/fs/ext2/inode.c
> @@ -355,9 +355,6 @@ static inline ext2_fsblk_t ext2_find_goal(struct inode *inode, long block,
>   *	@k: number of blocks need for indirect blocks
>   *	@blks: number of data blocks to be mapped.
>   *	@blocks_to_boundary:  the offset in the indirect block
> - *
> - *	return the total number of blocks to be allocate, including the
> - *	direct and indirect blocks.

You're right the comment is wrong but instead of deleting it, I'd rather
fix it like: "Return the number of direct blocks to allocate."

								Honza
Chengguang Xu July 3, 2020, 11:32 a.m. UTC | #2
On 7/3/20 6:20 PM, Jan Kara wrote:
> On Thu 02-07-20 17:56:36, Chengguang Xu wrote:
>> ext2_blks_to_allocate() only counts direct blocks need to be allocated,
>> return value does not include indirect blocks.
>>
>> Signed-off-by: Chengguang Xu <cgxu519@mykernel.net>
>> ---
>>   fs/ext2/inode.c | 3 ---
>>   1 file changed, 3 deletions(-)
>>
>> diff --git a/fs/ext2/inode.c b/fs/ext2/inode.c
>> index c8b371c82b4f..4df849e694dd 100644
>> --- a/fs/ext2/inode.c
>> +++ b/fs/ext2/inode.c
>> @@ -355,9 +355,6 @@ static inline ext2_fsblk_t ext2_find_goal(struct inode *inode, long block,
>>    *	@k: number of blocks need for indirect blocks
>>    *	@blks: number of data blocks to be mapped.
>>    *	@blocks_to_boundary:  the offset in the indirect block
>> - *
>> - *	return the total number of blocks to be allocate, including the
>> - *	direct and indirect blocks.
> 
> You're right the comment is wrong but instead of deleting it, I'd rather
> fix it like: "Return the number of direct blocks to allocate."
> 

That's fine, I can resend it with another comment fix together.

Thanks,
cgxu
diff mbox series

Patch

diff --git a/fs/ext2/inode.c b/fs/ext2/inode.c
index c8b371c82b4f..4df849e694dd 100644
--- a/fs/ext2/inode.c
+++ b/fs/ext2/inode.c
@@ -355,9 +355,6 @@  static inline ext2_fsblk_t ext2_find_goal(struct inode *inode, long block,
  *	@k: number of blocks need for indirect blocks
  *	@blks: number of data blocks to be mapped.
  *	@blocks_to_boundary:  the offset in the indirect block
- *
- *	return the total number of blocks to be allocate, including the
- *	direct and indirect blocks.
  */
 static int
 ext2_blks_to_allocate(Indirect * branch, int k, unsigned long blks,