diff mbox series

[v3,3/5] ext4: remove write io error check before read inode block

Message ID 20200620025427.1756360-4-yi.zhang@huawei.com
State New
Headers show
Series ext4: fix inconsistency since async write metadata buffer error | expand

Commit Message

Zhang Yi June 20, 2020, 2:54 a.m. UTC
After we add async write error check in ext4_journal_get_write_access(),
we can remove the partial fix for filesystem inconsistency problem
caused by reading old data from disk, which in commit <9c83a923c67d>
"ext4: don't read inode block if the buffer has a write error".

Signed-off-by: zhangyi (F) <yi.zhang@huawei.com>
 fs/ext4/inode.c | 9 ---------
 1 file changed, 9 deletions(-)
diff mbox series


diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
index f68afc5c0b2d..79b73a86ef6c 100644
--- a/fs/ext4/inode.c
+++ b/fs/ext4/inode.c
@@ -4289,15 +4289,6 @@  static int __ext4_get_inode_loc(struct inode *inode,
 	if (!buffer_uptodate(bh)) {
-		/*
-		 * If the buffer has the write error flag, we have failed
-		 * to write out another inode in the same block.  In this
-		 * case, we don't have to read the block because we may
-		 * read the old inode data successfully.
-		 */
-		if (buffer_write_io_error(bh) && !buffer_uptodate(bh))
-			set_buffer_uptodate(bh);
 		if (buffer_uptodate(bh)) {
 			/* someone brought it uptodate while we waited */