diff mbox series

[1/4] e2fsck: remove unused variable 'new_array'

Message ID 20200605081442.13428-1-lczerner@redhat.com
State New
Headers show
Series [1/4] e2fsck: remove unused variable 'new_array' | expand

Commit Message

Lukas Czerner June 5, 2020, 8:14 a.m. UTC
Signed-off-by: Lukas Czerner <lczerner@redhat.com>
---
 e2fsck/rehash.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Andreas Dilger June 5, 2020, 8:36 p.m. UTC | #1
> On Jun 5, 2020, at 2:14 AM, Lukas Czerner <lczerner@redhat.com> wrote:
> 
> Signed-off-by: Lukas Czerner <lczerner@redhat.com>

Reviewed-by: Andreas Dilger <adilger@dilger.ca>

> ---
> e2fsck/rehash.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/e2fsck/rehash.c b/e2fsck/rehash.c
> index 1616d07a..b356b92d 100644
> --- a/e2fsck/rehash.c
> +++ b/e2fsck/rehash.c
> @@ -109,7 +109,7 @@ static int fill_dir_block(ext2_filsys fs,
> 			  void *priv_data)
> {
> 	struct fill_dir_struct	*fd = (struct fill_dir_struct *) priv_data;
> -	struct hash_entry 	*new_array, *ent;
> +	struct hash_entry 	*ent;
> 	struct ext2_dir_entry 	*dirent;
> 	char			*dir;
> 	unsigned int		offset, dir_offset, rec_len, name_len;
> --
> 2.21.3
> 


Cheers, Andreas
Andreas Dilger June 5, 2020, 8:38 p.m. UTC | #2
> On Jun 5, 2020, at 2:14 AM, Lukas Czerner <lczerner@redhat.com> wrote:
> 
> Signed-off-by: Lukas Czerner <lczerner@redhat.com>
> ---
> e2fsck/rehash.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/e2fsck/rehash.c b/e2fsck/rehash.c
> index 1616d07a..b356b92d 100644
> --- a/e2fsck/rehash.c
> +++ b/e2fsck/rehash.c
> @@ -109,7 +109,7 @@ static int fill_dir_block(ext2_filsys fs,
> 			  void *priv_data)
> {
> 	struct fill_dir_struct	*fd = (struct fill_dir_struct *) priv_data;
> -	struct hash_entry 	*new_array, *ent;
> +	struct hash_entry 	*ent;

PS - there is a space before the tab after "hash_entry" that could be removed.
Ted could fix this when the patch is applied.

Cheers, Andreas
diff mbox series

Patch

diff --git a/e2fsck/rehash.c b/e2fsck/rehash.c
index 1616d07a..b356b92d 100644
--- a/e2fsck/rehash.c
+++ b/e2fsck/rehash.c
@@ -109,7 +109,7 @@  static int fill_dir_block(ext2_filsys fs,
 			  void *priv_data)
 {
 	struct fill_dir_struct	*fd = (struct fill_dir_struct *) priv_data;
-	struct hash_entry 	*new_array, *ent;
+	struct hash_entry 	*ent;
 	struct ext2_dir_entry 	*dirent;
 	char			*dir;
 	unsigned int		offset, dir_offset, rec_len, name_len;