| Message ID | 20200505154324.3226743-6-hch@lst.de |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | [01/11] ext4: fix EXT4_MAX_LOGICAL_BLOCK macro | expand |
On Tue 05-05-20 17:43:18, Christoph Hellwig wrote: > There is no caller left outside of ioctl.c. > > Signed-off-by: Christoph Hellwig <hch@lst.de> > Reviewed-by: Ritesh Harjani <riteshh@linux.ibm.com> > Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com> Looks good. You can add: Reviewed-by: Jan Kara <jack@suse.cz> Honza > --- > fs/ioctl.c | 4 +--- > include/linux/fs.h | 4 ---- > 2 files changed, 1 insertion(+), 7 deletions(-) > > diff --git a/fs/ioctl.c b/fs/ioctl.c > index 5e80b40bc1b5c..8fe5131b1deea 100644 > --- a/fs/ioctl.c > +++ b/fs/ioctl.c > @@ -307,8 +307,7 @@ static inline loff_t blk_to_logical(struct inode *inode, sector_t blk) > * If you use this function directly, you need to do your own locking. Use > * generic_block_fiemap if you want the locking done for you. > */ > - > -int __generic_block_fiemap(struct inode *inode, > +static int __generic_block_fiemap(struct inode *inode, > struct fiemap_extent_info *fieinfo, loff_t start, > loff_t len, get_block_t *get_block) > { > @@ -453,7 +452,6 @@ int __generic_block_fiemap(struct inode *inode, > > return ret; > } > -EXPORT_SYMBOL(__generic_block_fiemap); > > /** > * generic_block_fiemap - FIEMAP for block based inodes > diff --git a/include/linux/fs.h b/include/linux/fs.h > index 45cc10cdf6ddd..69b7619eb83d0 100644 > --- a/include/linux/fs.h > +++ b/include/linux/fs.h > @@ -3299,10 +3299,6 @@ static inline int vfs_fstat(int fd, struct kstat *stat) > extern const char *vfs_get_link(struct dentry *, struct delayed_call *); > extern int vfs_readlink(struct dentry *, char __user *, int); > > -extern int __generic_block_fiemap(struct inode *inode, > - struct fiemap_extent_info *fieinfo, > - loff_t start, loff_t len, > - get_block_t *get_block); > extern int generic_block_fiemap(struct inode *inode, > struct fiemap_extent_info *fieinfo, u64 start, > u64 len, get_block_t *get_block); > -- > 2.26.2 >
diff --git a/fs/ioctl.c b/fs/ioctl.c index 5e80b40bc1b5c..8fe5131b1deea 100644 --- a/fs/ioctl.c +++ b/fs/ioctl.c @@ -307,8 +307,7 @@ static inline loff_t blk_to_logical(struct inode *inode, sector_t blk) * If you use this function directly, you need to do your own locking. Use * generic_block_fiemap if you want the locking done for you. */ - -int __generic_block_fiemap(struct inode *inode, +static int __generic_block_fiemap(struct inode *inode, struct fiemap_extent_info *fieinfo, loff_t start, loff_t len, get_block_t *get_block) { @@ -453,7 +452,6 @@ int __generic_block_fiemap(struct inode *inode, return ret; } -EXPORT_SYMBOL(__generic_block_fiemap); /** * generic_block_fiemap - FIEMAP for block based inodes diff --git a/include/linux/fs.h b/include/linux/fs.h index 45cc10cdf6ddd..69b7619eb83d0 100644 --- a/include/linux/fs.h +++ b/include/linux/fs.h @@ -3299,10 +3299,6 @@ static inline int vfs_fstat(int fd, struct kstat *stat) extern const char *vfs_get_link(struct dentry *, struct delayed_call *); extern int vfs_readlink(struct dentry *, char __user *, int); -extern int __generic_block_fiemap(struct inode *inode, - struct fiemap_extent_info *fieinfo, - loff_t start, loff_t len, - get_block_t *get_block); extern int generic_block_fiemap(struct inode *inode, struct fiemap_extent_info *fieinfo, u64 start, u64 len, get_block_t *get_block);