Message ID | 20181231194836.3761-3-tytso@mit.edu |
---|---|
State | New |
Headers | show
Return-Path: <linux-ext4-owner@vger.kernel.org> X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-ext4-owner@vger.kernel.org; receiver=<UNKNOWN>) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=mit.edu Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=mit.edu header.i=@mit.edu header.b="HIa/dmnp"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 43T7D01VfYz9sLw for <patchwork-incoming@ozlabs.org>; Tue, 1 Jan 2019 06:48:47 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727469AbeLaTsq (ORCPT <rfc822;patchwork-incoming@ozlabs.org>); Mon, 31 Dec 2018 14:48:46 -0500 Received: from mail-eopbgr820113.outbound.protection.outlook.com ([40.107.82.113]:59061 "EHLO NAM01-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727405AbeLaTsp (ORCPT <rfc822;linux-ext4@vger.kernel.org>); Mon, 31 Dec 2018 14:48:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mit.edu; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=q8kUZqjzYmbB/Dy4nnDiIENN+tqWrFuJxJMN0b6jF04=; b=HIa/dmnprVUtSPyE/lugNQcmmbcclG43LkLEm8cj9tcVxLadS5MTPYfqahnXbq+aElzC/er5HbPJSJn3TDwVhxPq2YM7mnqTkm5M6Xe3eBxZTRu5QptY4eLZlXn89x/I1RC1XCcJFJXPFfU80DCAa8qCp5sQ+DjZtOgp/u2YPeg= Received: from BYAPR01CA0031.prod.exchangelabs.com (2603:10b6:a02:80::44) by SN6PR01MB4814.prod.exchangelabs.com (2603:10b6:805:d5::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1471.20; Mon, 31 Dec 2018 19:48:42 +0000 Received: from BY2NAM03FT024.eop-NAM03.prod.protection.outlook.com (2a01:111:f400:7e4a::209) by BYAPR01CA0031.outlook.office365.com (2603:10b6:a02:80::44) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.1471.20 via Frontend Transport; Mon, 31 Dec 2018 19:48:42 +0000 Authentication-Results: spf=pass (sender IP is 18.9.28.11) smtp.mailfrom=mit.edu; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=bestguesspass action=none header.from=mit.edu; Received-SPF: Pass (protection.outlook.com: domain of mit.edu designates 18.9.28.11 as permitted sender) receiver=protection.outlook.com; client-ip=18.9.28.11; helo=outgoing.mit.edu; Received: from outgoing.mit.edu (18.9.28.11) by BY2NAM03FT024.mail.protection.outlook.com (10.152.84.229) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.1471.13 via Frontend Transport; Mon, 31 Dec 2018 19:48:41 +0000 Received: from callcc.thunk.org ([104.200.153.98]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id wBVJmdGi006845 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 31 Dec 2018 14:48:40 -0500 Received: by callcc.thunk.org (Postfix, from userid 15806) id AD3337A01D0; Mon, 31 Dec 2018 14:48:38 -0500 (EST) From: Theodore Ts'o <tytso@mit.edu> To: Ext4 Developers List <linux-ext4@vger.kernel.org> CC: Theodore Ts'o <tytso@mit.edu>, <stable@kernel.org> Subject: [PATCH 3/3] ext4: track writeback errors using the generic tracking infrastructure Date: Mon, 31 Dec 2018 14:48:36 -0500 Message-ID: <20181231194836.3761-3-tytso@mit.edu> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20181231194836.3761-1-tytso@mit.edu> References: <20181231194836.3761-1-tytso@mit.edu> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:18.9.28.11; IPV:CAL; SCL:-1; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10019020)(136003)(376002)(39860400002)(346002)(396003)(2980300002)(189003)(199004)(26005)(47776003)(50226002)(26826003)(305945005)(6916009)(478600001)(8936002)(2906002)(1076003)(54906003)(8676002)(50466002)(36906005)(246002)(48376002)(106002)(75432002)(356004)(90966002)(52956003)(6266002)(42186006)(103686004)(786003)(316002)(86362001)(36756003)(2616005)(76176011)(51416003)(11346002)(126002)(476003)(5660300001)(2870700001)(4326008)(446003)(336012)(186003)(486006)(88552002)(106466001)(41533002); DIR:OUT; SFP:1102; SCL:1; SRVR:SN6PR01MB4814; H:outgoing.mit.edu; FPR:; SPF:Pass; LANG:en; PTR:outgoing-auth-1.mit.edu; MX:1; A:1; X-Microsoft-Exchange-Diagnostics: 1; BY2NAM03FT024; 1:yjfcq9KbRzeZdHMOc4MCVMAE1M3kBiqUdcLJG+XDAfzXCkfLj+imFOEtaIujri3lW0pYMeLz08/EoAZn7Sr2U8dNDq8huoVpplT7wFvj3b84t1v0kJuUX2iBMALyZ0nO Content-Type: text/plain X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2c649b5d-3710-4499-ff1e-08d66f58f7ad X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600109)(711020)(4608076)(4709027)(2017052603328)(7153060); SRVR:SN6PR01MB4814; X-Microsoft-Exchange-Diagnostics: 1; SN6PR01MB4814; 3:6cW0jxNxK36Ecgb4LigqPnkKsUnEcNRF3ugSQ7qDGOUwq/k8J9SqAjEP9ufqlR4YCKhiEffcnKth3F5bAoCsfEve+RH0Gb1e/3JcbavJYEiDr10Q0cvwPoScjqlcComlpHRTbJsYFc8lbn0UhMwIOhmp0640kwgCLXdEET1oS5pR2Dj58S9HY932Obude5qjXAzMSPlrJuR5ZDf4skwy+LvLMvgCk1zKTSBAjZKcgWHinLkK+owedRW5eZwbGLzVfBIULLV+x5aw3m8/W7JkVwMiEbKcg2wjhIu+gEpOMR05GzvC5r+zr9+AYDXFV0CqpE/gJk5847pCnvQy6bD+rA==; 25:2b/wRWRq3hVP1K6pswaOIbB3TAEP/UPkjXVirul7+tk8KTnCvCWVEOi8X6FihQ/KAb8mkuF5tG6fu9FF1xr4TaaIOkk+5P9S9OlqGk4WJv5nqeP8gjdkFp8Tv7MGulkRWFMHrrjaUnkuR21paKOwZkvSNcD30CYTzimI1Gjvp977ae6ufQvxI9wW+PVg26/sSzTAvuf8ZoQ+jbA+R+/CmbV5Ns15vYA8zibVEeINjUbdq6kHhYuwe5ZRXIxdZLyDDRk228bmvKxxGXdm43yNXqXx/B1W/bG4tPW6AkIr2mrZuIE64NyBPY1dHJdTb0wgPxT6Z6n1oR9zpr048uekCA==; 31:G5O9rgtMlQpiS1lzbh6pfL8mMkIxMoYUt17+0XX8Meejx12vKqtSD0PKYjvcyhyRLScOKtdLPJOvIVO9wPVkE+zWDFvGJgVCsJKKzKC4+AC4ps4ZvpkaJX5kT6MjHplkwjKjZEdyW2lys4CEJRS3IlyvcbEjuLFff7t+u9EPpqjNqjshWxkBPtzClOcm+tK0yuAv9pEFoRd+MEtQcYaxG4SEvqjUyS684V0A6njOD/0= X-MS-TrafficTypeDiagnostic: SN6PR01MB4814: X-LD-Processed: 64afd9ba-0ecf-4acf-bc36-935f6235ba8b,ExtAddr X-Microsoft-Exchange-Diagnostics: 1; SN6PR01MB4814; 20:ylKXLy8yqppF6EB5IpmfIS/2o/sBYlPtSTvJcey03CS1BEB7+hP5U7gDPwceSNk6I9RYIavNbngaPLqFTmDuUU80DrmjUMYlWmC/iDYQdEpf1pR7PL623iEmYnrGhDr3jZSjxPmFLPCRIcpaHPnZDMgYYFJvpzuQML+XRJPlZPF39m4W/F5Oq8/BsTgvMwyxDVk9UcUsMkEizNz266eQJ9SD/4QiQD2X/gT17sOUu02EUjYM/8I0IIVpplqPwMkZ55i/MZ/XweUCeOiaqJAa1wYe2CE29u+rUAkxYKUZiQs/PxIdlFb2GNqMiS/QNQeZuJmcheESLLKncfT7F6lHCJwPjYQqtnUlBGzpE5ixrl2KD2F6TOhBIWO7U0IN3SJj/ouN6bbzUfLDIKbQ4omY3kOm5jQoF9lK+UDQXhWwOH27nnIM2ztax3PgqsEGJ099wZ9+GMeIz+KjUlTDa4IFO9wTdja0CSA5ge64aG7Ih2fgF7FShV7e+e+erWuJpZe8; 4:nwWFBU5m+pIjrEq+Tg5wnM4NnQUXm6jmj4hMcEwOaixQQ6KuGyC98dcV9yk2jmnRze8YQtBAsSwxijhvcWrpJPMO1BUWU+scNsTvmfQm/HD4ei8q3Y9xOb+VulJGwq75iYNu24cOroXYTyqZQ3Ok/8dm14yRfX8d/psTwhoO1Sz0aCq+o8l/+00Lt5Ti4dZAvmQaROtnH0Iu1DCemJEGZRGBsnfZnefj/22vSM7WtBgxsr+DoqXo0fHRQME3Yetgf+9kd/X4Bh1hwxAiRsuN4A== X-Microsoft-Antispam-PRVS: <SN6PR01MB4814A33D499F2FC220CE67C1B5B20@SN6PR01MB4814.prod.exchangelabs.com> X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(3230021)(908002)(999002)(5005026)(6040522)(8220055)(2401047)(8121501046)(3231475)(944501520)(52105112)(3002001)(10201501046)(93006095)(93004095)(6041310)(20161123562045)(201703131423095)(201702281528075)(201702281529075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123558120)(20161123564045)(201708071742011)(7699051)(76991095); SRVR:SN6PR01MB4814; BCL:0; PCL:0; RULEID:; SRVR:SN6PR01MB4814; X-Forefront-PRVS: 0903DD1D85 X-Microsoft-Exchange-Diagnostics: 1; SN6PR01MB4814; 23:JkOGQxk2eHPGCMfzbmMpSPP8fpLaUXC5YCjioNay9YofnEScTUzexzmb+TCSsZboFCLJiCDjMuQMb5Euum03FpTHnwEDu0PSHtEpwGhXrNwPjHAhp9GtoT50l7P/fNopSYnHGX8mQwEp9vASJMLT4ViR3WeOWUSbGKr6M6xwz8gfcpmv67sc/ZRsXWN+ZtXsJ+CU21vArigvOwY+F/AuxIDD6F+DTMHRHZ/BmhAJ2T40GlALQMG1xhVdqoLdep9+yo3xFqybdhImdZS+P5YMYA/WtiL2f+cx8MKLo0AzKCPiunE02Fj0VEd/8o5FMaZx3Cc1QaF9qMk3/7boeotkjEHlTSF2f5U7+qmB0iLFlSQkL5e7sd3+8IMNE6vTW1Z/HlkUKkuoKrQTWjovCkVB/xDvdGeR/0+OvQJmeiSuPp8BqT2LhayG80fHr+Jq+iqCZSGZi0vxkzbWjlzM93k2D2KPZCJ8P0JIDgGOzuV7Yp8b2/cttQRBqghcSpDqRJRNucVOgroUstgrxIM4KMrlLB9AXAjT9SRNhVYq/2xU8Hr79MGFlxB5T6xRi9wKUzI00vhMpBDklyleMUZiyio09pDmFcdCyFqJE1UgxdIFNsCAwcsiozPVV5pnuVzkFimk6+rEYMd++iraO4TvW66qFf5sAOM978OQqF48leWGRsx2W1vzEd3mRUSj8uSyuI0Zh7t49yEzyLj43hkVFT2Z9EJmu4+RRh2/iRx7yvzYeDuh1M3UI92oVdCF7kwT+/P3QCCEc0P0d97wIg5VPTXHbWeyaaNJ7cfXCWLlfnSKOEA5M7Scd5QgPPs2u86geJWavwuA8LVQ7ULrcH7qdzFonOzPogcR+DJbl2cEx6qS83q76tJJH4lvAnmhTmY9f7Y06FxRweLVTx60ra5yVvIfpHtPRBO+BzXL5rumDOjHaucUca3ONDsRt6YocbBTRjFBPx0HyhCoOiU0ZW96YC6WO7JJ+ajKT0oxlKsmG50wt7Q8occdX4l3syoiNYveuFDFrcRn0lOdBYh+4TsrJl+518gahB6m34HoZroMC7Le7pVts5IiyFXd1t6UdT7fWDxbJIdjDkiCXxwFfXJKLXibBiVQkMFCh3W8DRsLqJ79KHsDIgUeQ4gUro1dEl/RRq0Gl/lGZgwH34ygEfM0Dpa6PQ== X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Message-Info: jDmyi7ha15nXThhKgZwiXF2NaRVPBF3vkUYo6WWxP9gH+RBokkZiKem9aFXqnNvkrV/N/ojM2cXYNkXZVD1dw41lEnUN1h8vjBA0BinuQEZ+nhR5HJsh4sSh81kt6kcIuSd9iadef/osY3WcMYD/Y4jp/x7ecbST8Uj9BjxEW4q+88R3jkC1leGEr+iDypUgWNrepdE/ndsvichPUAIwgxSmbWrXBIVL7gVQBUKV+iYTgdCCdRUuDT3DczRwwZmkEILDxO0q567dxzkSVlMLzZM6nZaXja5vLSkin2xMwTJQaURaM/T3R/mW0pqkBtM2 X-Microsoft-Exchange-Diagnostics: 1; SN6PR01MB4814; 6:vqEIT4Hwd7CLa0TGDOqpPKVxYkt16UJKiZEoMX9UdxIPHuofHCdg7MuhufFajbQNylOgYQ1gzQ516kB/DoftGjTPsAT66LYl40uTwN+4G8dy/PUuxcWPgRZH7mT9guLazDXPtFqXn5xQINLX1Ncj45omWI5PQlgrTtiE+V1LA6j25jivrsZi/Xt3F9NZUC/xlNVDOEJqzOi/tpI/BoX/sGb8itE5Fb7DBQajNU44KAGNtTU6Z2fhhxuypm+/lYIgNDvkWOKT+Gjrj/U3xpRagelpV0oKkHcq/VMruKiMlJr2HL7CPPCzZuVAw+rFWOe84OLZCC7sY+dlkF4Id1p0PcCAOPhmjAkRgM5nOuLwfn3LUTTm4Xu+gMNkgKLN6BjcHTLl7itytDrZ59ottX4iPAZe1yiudVyqKvfFf0Lx1amZMntvfz2tQDMDoFWRM5qp55knsQVix7F3awuPNZYQEQ==; 5:P1Z2QRebiaSlhFNOA6k/tA3v5+JUYgFKsRdes1HzTKy4dgh9YZGSr1OoilnxJZdKW7oLGMeJ9u32LsOfgw6kZspQALmxSmnOcBt+Wj37KBbrGfceTv9+WzkJ1zCG2sw7YRuZOBE47tvwQpKj7IEFKkyT2ZR0r8dso3Sq1MqwMRU=; 7:DfOKTC6YeTy50E/bKt+pcliWHBsgiVFOk2aad3B1xBdUF+0Dh0Vu44ymAD8FbBG705TervDe1g+kd3TVMHmT4x6IYdTkWLp+Gvi768cpvHk28usaEOsM7wSdfMtuAXrO9mEpjXsqSLmBxH1ywtbxhQ== SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: mit.edu X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Dec 2018 19:48:41.9710 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2c649b5d-3710-4499-ff1e-08d66f58f7ad X-MS-Exchange-CrossTenant-Id: 64afd9ba-0ecf-4acf-bc36-935f6235ba8b X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=64afd9ba-0ecf-4acf-bc36-935f6235ba8b; Ip=[18.9.28.11]; Helo=[outgoing.mit.edu] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR01MB4814 Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: <linux-ext4.vger.kernel.org> X-Mailing-List: linux-ext4@vger.kernel.org |
Series |
[1/3] ext4: avoid kernel warning when writing the superblock to a dead device
|
expand
|
diff --git a/fs/ext4/fsync.c b/fs/ext4/fsync.c index 87a7ff00ef62..712f00995390 100644 --- a/fs/ext4/fsync.c +++ b/fs/ext4/fsync.c @@ -164,6 +164,9 @@ int ext4_sync_file(struct file *file, loff_t start, loff_t end, int datasync) ret = err; } out: + err = file_check_and_advance_wb_err(file); + if (ret == 0) + ret = err; trace_ext4_sync_file_exit(inode, ret); return ret; }
We already using mapping_set_error() in fs/ext4/page_io.c, so all we need to do is to use file_check_and_advance_wb_err() when handling fsync() requests in ext4_sync_file(). Signed-off-by: Theodore Ts'o <tytso@mit.edu> Cc: stable@kernel.org --- fs/ext4/fsync.c | 3 +++ 1 file changed, 3 insertions(+)