Message ID | 20180831143352.22970-3-cgxu519@gmx.com |
---|---|
State | Not Applicable |
Headers | show |
Series | [v2,1/5] ext2: cache NULL when both default_acl and acl are NULL | expand |
On 2018/8/31 22:33, Chengguang Xu wrote: > default_acl and acl of newly created inode will be initiated > as ACL_NOT_CACHED in vfs function inode_init_always() and later > will be updated by calling xxx_init_acl() in specific filesystems. > Howerver, when default_acl and acl are NULL then they keep the value > of ACL_NOT_CACHED, this patch tries to cache NULL for acl/default_acl > in this case. > > Signed-off-by: Chengguang Xu <cgxu519@gmx.com> Acked-by: Chao Yu <yuchao0@huawei.com> Thanks,
Hi, Let me queue this patch in my -next. Thanks, On 09/02, Chao Yu wrote: > On 2018/8/31 22:33, Chengguang Xu wrote: > > default_acl and acl of newly created inode will be initiated > > as ACL_NOT_CACHED in vfs function inode_init_always() and later > > will be updated by calling xxx_init_acl() in specific filesystems. > > Howerver, when default_acl and acl are NULL then they keep the value > > of ACL_NOT_CACHED, this patch tries to cache NULL for acl/default_acl > > in this case. > > > > Signed-off-by: Chengguang Xu <cgxu519@gmx.com> > > Acked-by: Chao Yu <yuchao0@huawei.com> > > Thanks,
diff --git a/fs/f2fs/acl.c b/fs/f2fs/acl.c index 111824199a88..80aabdf92659 100644 --- a/fs/f2fs/acl.c +++ b/fs/f2fs/acl.c @@ -394,12 +394,16 @@ int f2fs_init_acl(struct inode *inode, struct inode *dir, struct page *ipage, error = __f2fs_set_acl(inode, ACL_TYPE_DEFAULT, default_acl, ipage); posix_acl_release(default_acl); + } else { + inode->i_default_acl = NULL; } if (acl) { if (!error) error = __f2fs_set_acl(inode, ACL_TYPE_ACCESS, acl, ipage); posix_acl_release(acl); + } else { + inode->i_acl = NULL; } return error;
default_acl and acl of newly created inode will be initiated as ACL_NOT_CACHED in vfs function inode_init_always() and later will be updated by calling xxx_init_acl() in specific filesystems. Howerver, when default_acl and acl are NULL then they keep the value of ACL_NOT_CACHED, this patch tries to cache NULL for acl/default_acl in this case. Signed-off-by: Chengguang Xu <cgxu519@gmx.com> --- v1->v2: - Coding style change. fs/f2fs/acl.c | 4 ++++ 1 file changed, 4 insertions(+)