From patchwork Wed Jan 10 21:19:05 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eric Whitney X-Patchwork-Id: 858575 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-ext4-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="reLFg1na"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3zH2281zFqz9sNr for ; Thu, 11 Jan 2018 08:19:12 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752700AbeAJVTK (ORCPT ); Wed, 10 Jan 2018 16:19:10 -0500 Received: from mail-qk0-f193.google.com ([209.85.220.193]:46219 "EHLO mail-qk0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752312AbeAJVTJ (ORCPT ); Wed, 10 Jan 2018 16:19:09 -0500 Received: by mail-qk0-f193.google.com with SMTP id l64so1006010qke.13; Wed, 10 Jan 2018 13:19:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :user-agent; bh=BUVgVmf/2LzGnTH2WO0xsYaX1HeX1M92TGU6M5UOpkQ=; b=reLFg1naLSdSG8o0FFIZVsxXhJm9QncCEB2xJMfGPaRzyC0iGVEocIsQs/xLIzmjh4 gEQ0t3+OddA6/ibmANNenduX5/IUiDoliHVJ13jLutbiBfXb8VXEklP8anWgzQSyUinn JF1+w/FCszKzcpX+mUR7cPuKA+5Ya3Neq9EBvQnlmH0SYGyFYfsEsr6CUWHu/iiM/cJk mK+xyZk7WCwE0QjBfYiil2mG7oUWphitrBPr2ItUFw6NUopH9PhgX9uW5sLKDNy1Z2QR xWBWJcyZQZwWzLdoV8WnwKyDntoe7xdw8QxyYB62VSqDgx7H+xWa2sGRE9PGERPK53bp fPIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:user-agent; bh=BUVgVmf/2LzGnTH2WO0xsYaX1HeX1M92TGU6M5UOpkQ=; b=AV5jSjLNqUS8Gpjzele6dumcTseumlT22ee3iGha8nWLquYUfHDWyFHUOi9JZSBDS4 T5+w8JeGeAOcZso+tgGloDC3JBpLWysdYlWrkFDsXZPp/VrK0e3Q/7K85c/BYB857PeW S00AQ1WTI+WUgO30LtG767dw+AGt5HyjcBHBQZYp/dS+karWkZL5orkEeBW6XYoude52 TXMZi3xQD8ABqEOssY3OA604XFqoCJdoKsIWbdh74R/aJ1CnWm6HNKXn23fi/4cDpDVp IDTUiXT16/ITbOYUf/Eu2OlQ/L1+/Gxn1jX4G7uZ/ntmIDcBk3PBrNKo6r+x5pMzIgV3 LHqA== X-Gm-Message-State: AKwxytdTaZaju9YXQ0xigMicW5IWK754ysFu2HeGzGmVC0YHZBxx5oYq 4Qv8mOX/lvgHWUwuSVnRbMxMGA== X-Google-Smtp-Source: ACJfBotH7r4EGtKVC8ZbH08zyH8xWQHLmfr/wUnQearqSqEINFZGWmIZOPGokNeDU4KTjUvBoZYb7A== X-Received: by 10.200.23.18 with SMTP id w18mr29666359qtj.131.1515619148464; Wed, 10 Jan 2018 13:19:08 -0800 (PST) Received: from localhost.localdomain (c-73-60-226-25.hsd1.nh.comcast.net. [73.60.226.25]) by smtp.gmail.com with ESMTPSA id p8sm11198990qtj.70.2018.01.10.13.19.06 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 10 Jan 2018 13:19:07 -0800 (PST) Date: Wed, 10 Jan 2018 16:19:05 -0500 From: Eric Whitney To: fstests@vger.kernel.org Cc: linux-ext4@vger.kernel.org Subject: [PATCH] common/rc: ext4 doesn't support O_DIRECT with data journaling Message-ID: <20180110211905.4ulqeqnwbs2bh66o@localhost.localdomain> MIME-Version: 1.0 Content-Disposition: inline User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org Modify _require_odirect() to skip O_DIRECT tests if the ext4 mount option data=journal has been applied. Because ext4 disables its O_DIRECT support when in data journaling mode, no significant value is obtained by running these tests and they consume a significant amount of run time. Additionally, this change eliminates the need to triage false negative O_DIRECT test results caused by test problems, as has occurred from time to time. Signed-off-by: Eric Whitney Reviewed-by: Theodore Ts'o --- common/rc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/common/rc b/common/rc index 9216efdb..86cc9665 100644 --- a/common/rc +++ b/common/rc @@ -2150,6 +2150,8 @@ _require_odirect() if [ $FSTYP = "ext4" ] ; then if echo "$MOUNT_OPTIONS" | grep -q "test_dummy_encryption"; then _notrun "ext4 encryption doesn't support O_DIRECT" + elif echo "$MOUNT_OPTIONS" | grep -q "data=journal"; then + _notrun "ext4 data journaling doesn't support O_DIRECT" fi fi testfile=$TEST_DIR/$$.direct