diff mbox series

ext4: skip project quota tests if the kernel does not support them

Message ID 20171008192746.20709-1-tytso@mit.edu
State Not Applicable, archived
Headers show
Series ext4: skip project quota tests if the kernel does not support them | expand

Commit Message

Theodore Ts'o Oct. 8, 2017, 7:27 p.m. UTC
In _scratch_enable_pquota, use _notrun if the file system with project
quotas enable can't be mounted, since that indicates the kernel
doesn't support that feature.

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
---
 common/quota | 3 +++
 1 file changed, 3 insertions(+)

Comments

Dave Chinner Oct. 8, 2017, 9:42 p.m. UTC | #1
On Sun, Oct 08, 2017 at 03:27:46PM -0400, Theodore Ts'o wrote:
> In _scratch_enable_pquota, use _notrun if the file system with project
> quotas enable can't be mounted, since that indicates the kernel
> doesn't support that feature.
> 
> Signed-off-by: Theodore Ts'o <tytso@mit.edu>

Looks fine.

Acked-by: Dave Chinner <dchinner@redhat.com>

-Dave
diff mbox series

Patch

diff --git a/common/quota b/common/quota
index f49728c2..d027a8c1 100644
--- a/common/quota
+++ b/common/quota
@@ -119,6 +119,9 @@  _scratch_enable_pquota()
 	[ "$FSTYP" != "ext4" ] && return
 
 	tune2fs -O quota,project $SCRATCH_DEV >>$seqres.full 2>&1
+	_scratch_mount >/dev/null 2>&1 \
+		|| _notrun "kernel doesn't support project feature on $FSTYP"
+	_scratch_unmount
 }
 
 #