From patchwork Wed Jun 21 21:21:22 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tahsin Erdogan X-Patchwork-Id: 779138 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3wtHjG4Nh0z9s2s for ; Thu, 22 Jun 2017 07:22:10 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.b="ca7MmGdM"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752600AbdFUVWI (ORCPT ); Wed, 21 Jun 2017 17:22:08 -0400 Received: from mail-pg0-f51.google.com ([74.125.83.51]:35713 "EHLO mail-pg0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752593AbdFUVWG (ORCPT ); Wed, 21 Jun 2017 17:22:06 -0400 Received: by mail-pg0-f51.google.com with SMTP id 132so48539495pgb.2 for ; Wed, 21 Jun 2017 14:22:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Mi45t1h8NYLWJQAr1ykWShBWliDPPzntAGbAYV1BTAM=; b=ca7MmGdM3wL3AMHXkrLMRp6xr8/IFWESLoiHfRujGuAezp6YWUGuvhpWys/08j7eY1 lZELRmv3xde+2k4Z1QdXw1cOfa8ht5xL8Swp4lRfZ3yRq5SME8D4ZrlAQlIDf41GYEcG 9zDNJ9hO98tOQsD7h53aYlQ4EEs/JKMNdr4bCm3lftAGH76B1pHO6ECRSD936rEh8ZBf m4KGylzdvxYfxFHoILHUiY4+UraiwPJxnUdy0sOJwdKefsdZsVFAdVJRcpSTczD2OoAe 3TSsd3HgJgC3qcExxU5QFEVCH5eot2fAqJK2OtQZDU+l0ZGHdUTsgDsOa3tmWtZs65dp glXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Mi45t1h8NYLWJQAr1ykWShBWliDPPzntAGbAYV1BTAM=; b=ScWmFmqop7HDw1nvU+e/akPUzJ+JpF5J+DPvCj0qj5nHzWrcY6xqXc1QlyoBk9hjo4 sfo9HQn5fSlrNAu9HHlGNSitE9YaOV+vYas8hWaYrUrnuDaAZNmn07SszharBeKNDvhk znJyJv3ATndDWwlDaSci3RlLv5AFo0UO/BPMyVy83zMZr5RPb1M9vjkSDVr3sUAX1rny Oqn8tmkG/AZYuVjVb2+fi675s4Uc4F29bUjwdgt/NfZdqS5d2/zBY0SrvDiiPoHiHcrh NQalJ8Z5ANntqEo3OgmyXtCRzWlcYTOTVT29CiPHzuxvLOrsrf63aj6fM36AYMjE1va3 OBEQ== X-Gm-Message-State: AKS2vOzl97yDDpKzvUQZ8ruh2kvR2+/QzKVV8BFk+MuO58L9Vpu7q9vI 5QuDpfB2mmHm9fiQ X-Received: by 10.84.128.1 with SMTP id 1mr44211909pla.244.1498080125877; Wed, 21 Jun 2017 14:22:05 -0700 (PDT) Received: from tahsin1.svl.corp.google.com ([100.123.230.167]) by smtp.gmail.com with ESMTPSA id s64sm1829980pfd.77.2017.06.21.14.22.05 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 21 Jun 2017 14:22:05 -0700 (PDT) From: Tahsin Erdogan To: Andreas Dilger , "Darrick J . Wong" , Jan Kara , Theodore Ts'o , linux-ext4@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Tahsin Erdogan Subject: [PATCH 12/32] ext4: add missing le32_to_cpu(e_value_inum) conversions Date: Wed, 21 Jun 2017 14:21:22 -0700 Message-Id: <20170621212142.16581-12-tahsin@google.com> X-Mailer: git-send-email 2.13.1.611.g7e3b11ae1-goog In-Reply-To: <20170621212142.16581-1-tahsin@google.com> References: <20170621212142.16581-1-tahsin@google.com> Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org Two places in code missed converting xattr inode number using le32_to_cpu(). Signed-off-by: Tahsin Erdogan --- fs/ext4/xattr.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/fs/ext4/xattr.c b/fs/ext4/xattr.c index 8e855fc2eb03..4dd8be16d175 100644 --- a/fs/ext4/xattr.c +++ b/fs/ext4/xattr.c @@ -1997,6 +1997,7 @@ ext4_xattr_delete_inode(handle_t *handle, struct inode *inode, struct ext4_inode *raw_inode; struct ext4_iloc iloc; struct ext4_xattr_entry *entry; + unsigned int ea_ino; int credits = 3, error = 0; if (!ext4_test_inode_state(inode, EXT4_STATE_XATTR)) @@ -2011,8 +2012,8 @@ ext4_xattr_delete_inode(handle_t *handle, struct inode *inode, entry = EXT4_XATTR_NEXT(entry)) { if (!entry->e_value_inum) continue; - if (ext4_expand_ino_array(lea_ino_array, - entry->e_value_inum) != 0) { + ea_ino = le32_to_cpu(entry->e_value_inum); + if (ext4_expand_ino_array(lea_ino_array, ea_ino) != 0) { brelse(iloc.bh); goto cleanup; } @@ -2044,8 +2045,8 @@ ext4_xattr_delete_inode(handle_t *handle, struct inode *inode, entry = EXT4_XATTR_NEXT(entry)) { if (!entry->e_value_inum) continue; - if (ext4_expand_ino_array(lea_ino_array, - entry->e_value_inum) != 0) + ea_ino = le32_to_cpu(entry->e_value_inum); + if (ext4_expand_ino_array(lea_ino_array, ea_ino) != 0) goto cleanup; entry->e_value_inum = 0; }