| Message ID | 20170531081517.11438-8-tahsin@google.com |
|---|---|
| State | Superseded, archived |
| Headers | show |
diff --git a/fs/ext4/xattr.c b/fs/ext4/xattr.c index 32ad2f2870e9..13daf634244b 100644 --- a/fs/ext4/xattr.c +++ b/fs/ext4/xattr.c @@ -2098,8 +2098,7 @@ ext4_xattr_inode_array_free(struct inode *inode, if (err) continue; /* for inode's i_count get from ext4_xattr_delete_inode */ - if (!list_empty(&EXT4_I(ea_inode)->i_orphan)) - iput(ea_inode); + iput(ea_inode); clear_nlink(ea_inode); iput(ea_inode); }
The ref count on ea_inode is incremented by ext4_xattr_inode_orphan_add() which is supposed to be decremented by ext4_xattr_inode_array_free(). The decrement is conditioned on whether the ea_inode is currently on the orphan list. However, the orphan list addition only happens when journaling is enabled. In non-journaled case,r we fail to release the ref count causing an error message like below. "VFS: Busy inodes after unmount of sdb. Self-destruct in 5 seconds. Have a nice day..." Signed-off-by: Tahsin Erdogan <tahsin@google.com> --- fs/ext4/xattr.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)